Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: FormView setting row spacing infinite loop & layout pin anchor remove cast appkit.LayoutAnchor #229

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Charliego3
Copy link
Contributor

  1. FormView embedding appkit.GridView, But GridView itself has a SetRowSpacing method, so the SetRowSpacing method of GridView should be called in FormView, Otherwise it will lead to an infinite loop. effect: f.GridView.SetRowSpacing(spacing)
  2. appkit.ILayoutAnchor now has the ConstraintEqualToAnchorConstant method. There is no need to cast it to appkit.LayoutAnchor, otherwise it will cause panic, because for example, the return value of view.TopAnchor() is appkit.LayoutYAxisAnchor instead of appkit.LayoutAnchor. If forced conversion is performed, will cause panic

@progrium
Copy link
Owner

Awesome, sorry I missed this until now. Thanks!

@progrium progrium merged commit ccec524 into progrium:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants