Plugin nginx-vhosts includes files in folder nginx.conf.d

[motin]

This allows dokku ops and other plugins to set custom per-app nginx configuration without having to overwrite the file post-deploy or in nginx-pre-reload.

[motin]

Once this PR is merged, we can add https://github.com/neam/dokku-nginx-vhosts-custom-configuration to the list of Dokku plugins in the wiki.

[ghost]

CI is currently broken - see #568 for details. I haven't had time to try and diagnose lately

[alecgorge]

This file will also need to be updated in most use cases I would imagine: https://github.com/wmluke/dokku-domains-plugin/blob/master/commands#L62

[motin]

@alecgorge, no I rewrote the dokku-domains-plugin to not replace the existing configuration, see wmluke/dokku-domains-plugin#11 (Fixes wmluke/dokku-domains-plugin#10)

[javoire]

If I'd want to have two server names like

server_name myapp.apps.mydomain.com myapp.com;

Would this be possible to do with the change suggested in this branch?

[motin]

@javoire: This PR does not make it possible to add an extra server_name configuration directive in order to configure multiple domains. For that, you should instead check out https://github.com/neam/dokku-custom-domains

[javoire]

Ok thanks :)

Jonatan Dahl http://www.linkedin.com/pub/jonatan-dahl/31/127/813
+46 (0) 70 450 39 16
Student, MSc Human-Computer Interaction
The Royal Institute of Technology (KTH)

On 22 May 2014 00:12, Fredrik Wollsén notifications@github.com wrote:

@javoire https://github.com/javoire: You can't add an extra server_name
configuration directive in order to configure multiple domains. For that,
you should instead check out wmluke/dokku-domains-plugin#11wmluke/dokku-domains-plugin#11

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/579#issuecomment-43821142
.

[motin]

Can this PR be accepted? :)

[AlJohri]

+1

[timsuchanek]

+1!

[sibsfinx]

+1

[mikexstudios]

Another way to set per-app nginx configs (including multiple domains) is using: https://github.com/mikexstudios/dokku-nginx-alt

[motin]

Another way to set per-app nginx configs (including multiple domains) is using: https://github.com/mikexstudios/dokku-nginx-alt

Yes, I tried that first but using it meant swapping out a huge portion of what is considered dokku core. This PR is a one-line change meant to make it easy for plugins to set per-app nginx configuration directives.

[mikexstudios]

👍

[kirbysayshi]

Any chance on this getting merged soon? I need to increase the request size limit, and something like this seems the easiest path forward.

[motin]

+1 for getting this merged. We use this patch together with https://github.com/neam/dokku-nginx-vhosts-custom-configuration for increasing upload size limits and timeout values.

[nikfalstie]

I have manually inserted this change into /dokku/plugins/nginx-vhosts/post-deploy on my server.
However, it seems that changes to the post-deploy script are ignored i.e. a new nginx.conf file gets generated, when I push or do a dokku deploy, but it does not contain my changes.

I'm a bit new to Docker and Dokku, so it might be something obvious.

Any suggestions?

Thanks in advance.

[motin]

@nikfalstie: The default location for the nginx-vhost plugin is /var/lib/dokku/plugins/nginx-vhosts - try modifying it there.

[motin]

Btw, we have used this patch in https://github.com/neam/dokku-host-provisioning for about 4.5 months now and it 1. works great and haven't caused any side effects for us and 2. is essential for us in order to for instance allow large file uploads (even if client_max_body_size is increased in the the buildpack nginx configuration, file uploads otherwise fails since the vhost nginx configuration limits this before it even gets to the buildpack's nginx configuration).

[nikfalstie]

I knew it was something stupid - just thought I had looked everywhere for other post-deploy files. Thanks a lot for your help :)

[motin]

@progrium: Any chance merging this for 0.3.0 release?

[aral]

@motin Until this is merged, it would probably be a good idea to add a note to https://github.com/neam/dokku-nginx-vhosts-custom-configuration that the plugin does not work without this patch. I stumbled on the Git repo and didn’t realise it didn’t work on the current release version of Dokku and others might lose time over that also. Thanks for the awesome plugin + patch, by the way :)

[josegonzalez]

I need to make a release (0.2.4) but this will likely be out for 0.3.0.

[motin]

@aral Glad you find it useful :) The fact that the plugin requires this PR is stated in the docs: https://github.com/progrium/dokku/blob/master/docs/plugins.md#dokku-features and hopefully this will be merged soon so that it doesn't need it anymore. I'll update the PR to include change in docs.

I need to make a release (0.2.4) but this will likely be out for 0.3.0.

@josegonzalez It doesn't seem to be included in 0.3.0, any idea of when it will be merged?

[motin]

Btw, this is a 100% backward-compatible change, so it could be released in 0.3.1

[josegonzalez]

Merged, it'll be out in 0.3.1. Thanks for the PR.