-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update existing nginx.conf instead #11
Conversation
this looks awesome! nice job @motin |
Oops, closed on accident. ;-) |
I propose that such feature is either merged into the nginx-vhosts plugin or a separate plugin. Either way, the plugin should use an include file (as per dokku/dokku#579) or alter the existing nginx.conf instead of overwriting it. |
Thanks jgallen23, glad you like it :) |
Hi @motin, I appreciate your feedback and PR. Unfortunately, this PR deletes all the SSL support that we have been working on and that I plan to release soon. Also, your PR breaks our CI build. To move forward...
You can run the test suite with Thanks, |
A. Remember, we shouldn't aim to create multi-purpose plugins. Remember the Unix philosophy: Write programs that do one thing and do it well. Write programs to work together. With this in mind, first step is to do either 1 or 2.
B. In this plugin, make sure that adding custom domains still works when the user is using the other SSL plugin or the enhanced standard nginx-vhosts plugin.
Sure. |
What are the SSL enhancements btw? Comparing https://github.com/progrium/dokku/blob/master/plugins/nginx-vhosts/post-deploy#L30 and https://github.com/wmluke/dokku-domains-plugin/blob/develop/commands#L63 indicates that the implementations are similar but vaguely different. Fragmentation is dangerous and may not be healthy for the dokku community. For instance, a dokku user that has followed the official instructions https://github.com/progrium/dokku#tlsspdy-support to set up SSL support will have his/her set-up broken after installing this plugin. |
@motin it might make sense to release yours as a different plugin since it is quite a bit different from the existing |
@jgallen23, I'd like to prevent further fragmentation if possible. There are already two dokku-domains plugins and even some PRs about including domains-support in the nginx-vhosts plugin... The confusion for new dokku users is already too high. |
echo "$cert_name, $domains" > $SSL_DOMAINS_FILE | ||
|
||
cat<<EOF > $DOKKU_ROOT/$APP/nginx-domains-ssl-$cert_name.conf | ||
upstream $APP-domains-ssl-$cert_name { server 127.0.0.1:$PORT; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR does not include SSL support, so we can't remove this.
Hi @motin, As I said in #10 (comment), I appreciate your feedback and passion, but I feel that this PR is not a good fit for Cheers, |
Agree, the current implementation does not properly handle the SSL case, but please keep this PR open - otherwise I can't push new commits to this branch with the proper SSL support. |
For anyone interested, this PR will never be included in the dokku-domains-plugin repo (See #10), so I released a fork containing this PR earlier this morning: https://github.com/neam/dokku-custom-domains |
Fixes #10