Fix race condition in signal handling, and error handling #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to:
Description:
Line 265 causes a race condition when querying the
ProcessState
(specifically theWaitStatus
) in a goroutine, sincecmd.Wait()
concurrently modifies it. This PR fixes this race condition, and also adds proper error handling when a signal is raised. The current error handling returns a -1 status when the process exits due to a signal: