updates bash static version (including binaries) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid having to change the readme file whenever a newer statically linked version of bash is used, removes version number
changes bash statically linked version strips linux binary to reduce size # detects if upx is installed and if so, compress to further reduce binary sizes
|
Can you add in the version that you added? As well, would be good if you could document how you created the new upx compressed files :) |
|
if you check the modified Makefile... it shows the exact commands how to create the upx files. BASH_STATIC_VERSION is defined in the makefile at the top. curl -#SLk https://github.com/robxu9/bash-static/releases/download/$(BASH_STATIC_VERSION)/bash-linux \
> $(BASH_DIR)/linux/bash && strip $(BASH_DIR)/linux/bash
curl -#SLk https://github.com/robxu9/bash-static/releases/download/$(BASH_STATIC_VERSION)/bash-osx \
> $(BASH_DIR)/osx/bash
chmod +x $(BASH_DIR)/*/bash
# if upx is present, compress bash binaries
if [ `command -v upx` ]; then upx --8mib-ram --best --brute --ultra-brute -9 $(BASH_DIR)/*/bash; fi
basically, if upx is found, then run |
|
this 213414f shows everything and is exactly how i have made them |
mathieu-aubin
commented
Feb 11, 2020
| > $(BASH_DIR)/osx/bash | ||
| chmod +x $(BASH_DIR)/**/* |
There was a problem hiding this comment.
i removed the double star ** here since this is only available when shopt globstar is enabled
mathieu-aubin
commented
Feb 11, 2020
| curl -Ls https://github.com/robxu9/bash-static/releases/download/4.3.30/bash-osx \ | ||
|
|
||
| curl -#SLk https://github.com/robxu9/bash-static/releases/download/$(BASH_STATIC_VERSION)/bash-linux \ | ||
| > $(BASH_DIR)/linux/bash && strip $(BASH_DIR)/linux/bash |
There was a problem hiding this comment.
only linux executable gets stripped
|
<3 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr includes updated binaries for linux and osx, stripped and compressed with upx