Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep line-endings normalized & configure text editors to follow Limnoria style guidelines #1561

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

Mikaela
Copy link
Contributor

@Mikaela Mikaela commented Sep 29, 2023

As .gitattributes was already there I thought it might be a good idea to add end-of-line normalization of git from this decade.


When writing #1560, I noticed that my nvim was making tabs which is against Limnoria's style guidelines. Thus I added .editorconfig that follows the Limnoria style guidelines so supported editors and plugins will automatically attempt to use four spaces as indentation and stay within 79 lines.

I am not sure if I should add it to .gitattributes as export-ignore, because someone could download the repository archive and send a patch by email or pastebin and thus benefit from .editorconfig being present.

I think copying it to repositories containing plugins would also be a good idea.

Copy link
Owner

@progval progval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks

.editorconfig Outdated Show resolved Hide resolved
# EditorConfig is awesome: https://EditorConfig.org
root = true

[*]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[*]
[*.py]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't have helped with #1560 as requirements.txt wouldn't match *.py and thus my editor would have made tabs there. How about 49f9cdc instead?

@progval
Copy link
Owner

progval commented Sep 29, 2023

thanks!

@progval progval merged commit a46a073 into progval:testing Sep 29, 2023
12 checks passed
@Mikaela Mikaela deleted the editorconfig branch September 29, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants