report channel counts and modes in status #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
requested changes
Oct 5, 2023
plugins/Status/plugin.py
Outdated
Comment on lines
116
to
120
| response_lines.append( | ||
| f"I am connected to {network_name} as {nicks[network_name]}, Channels: {channel_counts[network_name]}, " | ||
| f"Ops: {op_counts[network_name]}, Half-Ops: {halfop_counts[network_name]}, " | ||
| f"Voiced: {voice_counts[network_name]}, Regular: {normal_counts[network_name]} " | ||
| ) |
There was a problem hiding this comment.
Please keep the _() wrapper and %s substitution so it's translatable.
plugins/Status/plugin.py
Outdated
| f"Voiced: {voice_counts[network_name]}, Regular: {normal_counts[network_name]} " | ||
| ) | ||
|
|
||
| irc.reply("".join(response_lines)) |
There was a problem hiding this comment.
Please keep %L formatting so items are joined according to the config and locale
plugins/Status/plugin.py
Outdated
| if world.profiling: | ||
| L.append(_('I am currently in code profiling mode.')) | ||
| irc.reply(' '.join(L)) | ||
| irc.reply(_('I am currently in code profiling mode.')) |
There was a problem hiding this comment.
And keep this in the list, so it does not send it as an independent message
|
Is this more or less what you meant? If not, what would be the desired format for the output? |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1183
If accepted, could you please add the
hacktoberfest-acceptedlabel? I understand you do not want your repository to participate, but this PR still can.