Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ignore trailing chars/spaces for Karma #1579

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

prdes
Copy link
Contributor

@prdes prdes commented Jun 21, 2024

The trailing characters , and : have been chosen as they are the most popular ones appended to tab completed nicks.

Solves #1495

@progval
Copy link
Owner

progval commented Jun 21, 2024

Could you add \t too?

@prdes prdes force-pushed the fix/karma_delimiters branch from a6d61cd to 36026fb Compare June 21, 2024 06:52
Signed-off-by: Pratyush Desai <pratyush.desai@liberta.casa>
@prdes prdes marked this pull request as draft June 21, 2024 07:10
@prdes prdes force-pushed the fix/karma_delimiters branch from 36026fb to c61c45e Compare June 21, 2024 07:21
@prdes prdes marked this pull request as ready for review June 21, 2024 07:29
@jlu5 jlu5 changed the base branch from testing to master June 28, 2024 02:01
@jlu5 jlu5 merged commit 01cdfee into progval:master Jun 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants