Commits on May 5, 2023

1. Remove the OnSessionReleased callback from OperationalSessionSetup. …

   Since OperationalSessionSetup is ephemeral, it only holds on to a session while
   it's notifying its listeners, after which it will delete itself.
   
   Right now it was deleting itself from OnSessionReleased, but that means it could
   end up with a double-delete... and also, it's already notifying listeners if it
   has a session, so there is no point, or ability, to notify them again on session
   release.
   
   The changes here:
   
   1. Take out the OnSessionReleased that couldn't do anything except lead to
      use-after-free.
   2. Fix a bug on OnSessionEstablished where if we got a session that's not usable
      we leaked and left our listeners hanging instead of just notifying our
      listeners with error.

   

   bzbarsky-apple committed May 5, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for e3fe5c7
   • Browse repository at this point

   Copy the full SHA

   e3fe5c7 View commit details

   Browse the repository at this point in the history