Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data type check in MTRDevice's invokeCommandWithEndpointID. #35834

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Fix data type check in MTRDevice's invokeCommandWithEndpointID. #35834

merged 1 commit into from
Sep 28, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

We were checking two NSStrings for pointer-equality, when we should be testing for logical equality.

@bzbarsky-apple
Fix data type check in MTRDevice's invokeCommandWithEndpointID.
e57e270 
We were checking two NSStrings for pointer-equality, when we should be testing
for logical equality.
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform specific fix with platform owner review.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 28, 2024 •
edited
Loading

PR #35834: Size comparison from 4a3923e to e57e270

Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4a3923e e57e270 change % change
bl602 lighting-app bl602 FLASH 1280536 1280536 0 0.0
RAM 95848 95848 0 0.0
bl602+mfd FLASH 1294402 1294402 0 0.0
RAM 95992 95992 0 0.0
bl602+rpc FLASH 1320486 1320486 0 0.0
RAM 104272 104272 0 0.0
bl702 lighting-app bl702 FLASH 944368 944368 0 0.0
RAM 15145 15145 0 0.0
bl702+mfd FLASH 946768 946768 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039932 1039932 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 646830 646830 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 894660 894660 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 961028 961028 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 963650 963650 0 0.0
RAM 16964 16964 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829396 829396 0 0.0
RAM 123300 123300 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814432 814432 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760428 760428 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 744664 744664 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616202 616202 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 656258 656258 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677765 677765 0 0.0
RAM 78516 78516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697609 697609 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697609 697609 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654545 654545 0 0.0
RAM 73584 73584 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613829 613829 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633457 633457 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633457 633457 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633125 633125 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652833 652833 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652833 652833 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608469 608469 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628329 628329 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628329 628329 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933356 933356 0 0.0
RAM 135884 135884 0 0.0
lock-app BRD2605a FLASH 741024 741016 -8 -0.0
RAM 230240 230240 0 0.0
BRD4338a FLASH 741688 741680 -8 -0.0
RAM 230272 230272 0 0.0
window-app BRD4187C FLASH 1016440 1016432 -8 -0.0
RAM 127804 127804 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1537644 1537644 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548086 1548086 0 0.0
IRAM 117039 117039 0 0.0
linux chip-tool-ipv6only arm64 unknown 20512 20512 0 0.0
FLASH 11211776 11211776 0 0.0
RAM 605368 605368 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4312368 4312368 0 0.0
RAM 242808 242808 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913448 913448 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885032 885032 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846960 846960 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581776 581776 0 0.0
RAM 70776 70776 0 0.0
k32w1+release FLASH 595680 595680 0 0.0
RAM 62992 62992 0 0.0
mcxw71+release FLASH 595432 595432 0 0.0
RAM 62992 62992 0 0.0
light k32w0+release FLASH 617812 617812 0 0.0
RAM 70248 70248 0 0.0
k32w1+release FLASH 681632 681632 0 0.0
RAM 48632 48632 0 0.0
mcxw71+release FLASH 681648 681648 0 0.0
RAM 48632 48632 0 0.0
lock k32w1+release FLASH 703952 703952 0 0.0
RAM 67132 67132 0 0.0
mcxw71+release FLASH 703976 703976 0 0.0
RAM 67132 67132 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645380 1645380 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551380 1551380 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467196 1467196 0 0.0
RAM 200696 200696 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463940 1463940 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 659520 659520 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 617484 617484 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481080 481080 0 0.0
RAM 144692 144692 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620088 620088 0 0.0
RAM 50988 50988 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687320 687320 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780254 780254 0 0.0
RAM 110780 110780 0 0.0
bridge-app tlsr9258a FLASH 681090 681090 0 0.0
RAM 91644 91644 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 619850 619850 0 0.0
RAM 50940 50940 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707792 707792 0 0.0
RAM 74280 74280 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624812 624812 0 0.0
RAM 144316 144316 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810464 810464 0 0.0
RAM 99448 99448 0 0.0
lock-app-dfu tlsr9528a FLASH 655696 655696 0 0.0
RAM 67000 67000 0 0.0
ota-requestor-app tlsr9258a FLASH 697066 697066 0 0.0
RAM 91236 91236 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633474 633474 0 0.0
RAM 55816 55816 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610664 610664 0 0.0
RAM 53060 53060 0 0.0
shell tlsr9518adk80d FLASH 467342 467342 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 626980 626980 0 0.0
RAM 52660 52660 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652800 652800 0 0.0
RAM 56608 56608 0 0.0
thermostat tlsr9518adk80d FLASH 637394 637394 0 0.0
RAM 53452 53452 0 0.0
window-covering tlsr9118bdk40d FLASH 523580 523580 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1724256 1724256 0 0.0
RAM 89076 89076 0 0.0
chip-tool-ubsan arm unknown 10344 10344 0 0.0
FLASH 17358034 17358034 0 0.0
RAM 7563028 7563028 0 0.0

@mergify mergify bot merged commit 6bbe1d6 into project-chip:master Sep 28, 2024
69 checks passed
@bzbarsky-apple bzbarsky-apple deleted the fix-device-invoke-sanity-check branch September 28, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtov-sfy jtov-sfy Awaiting requested review from jtov-sfy

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @woody-apple @jtung-apple