Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IM] Handle internal fatal error in BufferReadCallback #36187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Oct 21, 2024

Revive #30965

Issue: If onError has been called from BufferedReadCallback when processing multiple attrbitues, potentially onError or onAttribute or onEvent could be called again from ReadClient, as a result, the behavior in application could be unexpected, crash is possible. note: the errors in BufferredReadCallback are treated as fatal ones.

Solution: In order to resolve the above issue, we add mDataBufferingError to store internal error in BufferredReadCallback, we call a new introduced GetLastError callback in readClient after each onAttribute and onEvent, if any fatal error happens, we propagate the error to Close in ReadClient, for any new callback class that inherits ReadClient::Callback, if there is a fatal error, ReadClient can get aware of this error from GetLastError.

Copy link

semanticdiff-com bot commented Oct 21, 2024

Review changes with  SemanticDiff

@github-actions github-actions bot added the app label Oct 21, 2024
@yunhanw-google yunhanw-google force-pushed the feature/handle_error_BufferReaderCallback branch from f615c29 to a75bf72 Compare October 21, 2024 22:04
Copy link

github-actions bot commented Oct 21, 2024

PR #36187: Size comparison from 9ee0499 to 2167712

Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 9ee0499 2167712 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1350008 1350020 12 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647788 647788 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825274 825274 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1054200 1054200 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 975048 975048 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829564 829580 16 0.0
RAM 123452 123452 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814872 814888 16 0.0
RAM 125332 125332 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761460 761476 16 0.0
RAM 113824 113824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745704 745720 16 0.0
RAM 114016 114016 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617258 617266 8 0.0
RAM 205908 205908 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657306 657322 16 0.0
RAM 206060 206060 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678589 678613 24 0.0
RAM 78668 78668 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698433 698457 24 0.0
RAM 81300 81300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698433 698457 24 0.0
RAM 81300 81300 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655377 655393 16 0.0
RAM 73736 73736 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614933 614973 40 0.0
RAM 71628 71628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634569 634601 32 0.0
RAM 74180 74180 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634569 634601 32 0.0
RAM 74180 74180 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634213 634229 16 0.0
RAM 74676 74676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653921 653937 16 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653921 653937 16 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609525 609541 16 0.0
RAM 68764 68764 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629385 629401 16 0.0
RAM 71396 71396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629385 629401 16 0.0
RAM 71396 71396 0 0.0
efr32 lock-app BRD4187C FLASH 925248 925280 32 0.0
RAM 159708 159708 0 0.0
BRD4338a FLASH 741432 741440 8 0.0
RAM 231008 231008 0 0.0
window-app BRD4187C FLASH 1018236 1018236 0 0.0
RAM 128052 128052 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1539960 1539978 18 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1550166 1550178 12 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781331 2781479 148 0.0
RAM 129520 129520 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6092456 6092660 204 0.0
RAM 523840 523856 16 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5423032 5423180 148 0.0
RAM 242416 242416 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751960 4752108 148 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 13159438 13159962 524 0.0
RAM 584402 584554 152 0.0
chip-tool-ipv6only arm64 unknown 21408 21408 0 0.0
FLASH 11718768 11718928 160 0.0
RAM 635328 635480 152 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11388889 11389413 524 0.0
RAM 584794 584954 160 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4578356 4578504 148 0.0
RAM 205336 205336 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5693889 5693889 0 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801506 4801654 148 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430888 4431036 148 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569660 4569808 148 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3115949 3116157 208 0.0
RAM 160368 160368 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4319872 4319968 96 0.0
RAM 242896 242896 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6031989 6032453 464 0.0
RAM 596256 596304 48 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11364621 11365053 432 0.0
RAM 675776 675888 112 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915528 915552 24 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885992 886012 20 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848936 848936 0 0.0
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582296 582312 16 0.0
RAM 70948 70948 0 0.0
mcxw71+release FLASH 596928 596944 16 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 618932 618948 16 0.0
RAM 70412 70412 0 0.0
k32w1+release FLASH 683160 683176 16 0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746712 746728 16 0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647604 1647628 24 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553684 1553700 16 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1468004 1468020 16 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464980 1464996 16 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660600 660616 16 0.0
RAM 105396 105396 0 0.0
lock-app qpg6105+debug FLASH 618612 618628 16 0.0
RAM 99864 99864 0 0.0
stm32 light STM32WB5MM-DK FLASH 481936 481952 16 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 681164 681170 6 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620814 620820 6 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708794 708712 -82 -0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625764 625770 6 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811772 811778 6 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1729708 1729784 76 0.0
RAM 90108 90116 8 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18324534 18324966 432 0.0
RAM 7969228 7969464 236 0.0

src/app/ReadClient.h Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/handle_error_BufferReaderCallback branch 2 times, most recently from bb45a1c to 7a20bd8 Compare October 29, 2024 23:17
Copy link

github-actions bot commented Oct 29, 2024

PR #36187: Size comparison from fef41bd to 7a20bd8

Full report (3 builds for cc32xx, stm32)
platform target config section fef41bd 7a20bd83 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 625798 625798 0 0.0
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 665774 665774 0 0.0
RAM 206284 206284 0 0.0
stm32 light STM32WB5MM-DK FLASH 481392 481400 8 0.0
RAM 144844 144844 0 0.0

@yunhanw-google yunhanw-google force-pushed the feature/handle_error_BufferReaderCallback branch from 7a20bd8 to 44484ae Compare October 29, 2024 23:32
Copy link

github-actions bot commented Oct 29, 2024

PR #36187: Size comparison from fef41bd to 44484ae

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section fef41bd 44484ae change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349306 1349302 -4 -0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647028 647064 36 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 824592 824628 36 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053582 1053618 36 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974366 974402 36 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 836124 836132 8 0.0
RAM 123676 123676 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 821768 821768 0 0.0
RAM 125556 125556 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 768476 768484 8 0.0
RAM 114048 114048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 752720 752728 8 0.0
RAM 114240 114240 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 625798 625798 0 0.0
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 665774 665774 0 0.0
RAM 206284 206284 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678085 678093 8 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697937 697945 8 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697937 697945 8 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654873 654881 8 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614637 614661 24 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634273 634297 24 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634273 634297 24 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634149 634157 8 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653857 653865 8 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653857 653865 8 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609429 609437 8 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629281 629289 8 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629281 629289 8 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 926068 926068 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 740568 740552 -16 -0.0
RAM 232580 232580 0 0.0
window-app BRD4187C FLASH 1017272 1017272 0 0.0
RAM 128264 128264 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1537464 1537508 44 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1548126 1548126 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2731595 2731605 10 0.0
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6021350 6021416 66 0.0
RAM 523872 523888 16 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5358592 5358602 10 0.0
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4700450 4700460 10 0.0
RAM 218400 218400 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12901220 12901606 386 0.0
RAM 584466 584618 152 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11029376 11029456 80 0.0
RAM 635400 635552 152 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11308753 11309139 386 0.0
RAM 584922 585114 192 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4527502 4527512 10 0.0
RAM 205368 205368 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5239621 5239893 272 0.0
RAM 465432 465464 32 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5638961 5638961 0 0.0
RAM 228520 228520 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4748870 4748880 10 0.0
RAM 204520 204520 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4375630 4375640 10 0.0
RAM 198240 198240 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4513870 4513880 10 0.0
RAM 202808 202808 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3048605 3048685 80 0.0
RAM 160336 160336 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4117192 4117192 0 0.0
RAM 242936 242936 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5971893 5972197 304 0.0
RAM 596304 596352 48 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11108589 11108877 288 0.0
RAM 694552 694664 112 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913336 913348 12 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884780 884804 24 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847396 847396 0 0.0
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582296 582312 16 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596784 596784 0 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 618852 618868 16 0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 682936 682944 8 0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746560 746560 0 0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1641508 1641500 -8 -0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549052 1549052 0 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1465636 1465636 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463300 1463300 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660304 660312 8 0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618380 618380 0 0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481392 481400 8 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 680800 680832 32 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620426 620458 32 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708260 708204 -56 -0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625062 625094 32 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811072 811104 32 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1712792 1712844 52 0.0
RAM 90140 90148 8 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 17942270 17942654 384 0.0
RAM 7811564 7811840 276 0.0

/*
* Get the last internal fatal error in callback
*/
virtual CHIP_ERROR GetLastError() const { return CHIP_NO_ERROR; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this new API needed? This is making all ReadClient consumers pay extra flash costs for an internal implementation details of BufferedReadCallback (which is meant for "capable clients" only, and is better able to shoulder such costs).

If this is trying to implement the suggestion from #30965 (comment), then that's not what the suggestion was. The suggestion was that BufferedReadCallback store some internal state that will allow it to maintain the relevant invariants and just start ignoring calls from ReadClient after it reaches that error state, no? As far as the ReadClient is concerned, there would be no changes in behavior of any sort here.

Copy link
Contributor Author

@yunhanw-google yunhanw-google Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we introduce GetLastError as new callback in ReadClient, we check GetLastError in the end of onAttributeData or onEventData in ReadClient, no matter what kind of chained callback we have, we could lead to Close call in readClient for read or subscribe, for resubscription case, it would depend on which error OnResubscriptionNeeded returns, OnResubscriptionNeeded is not only conveying this error to contrloller applicaiton, but also decides how to translate the error, for example, application can skip all errors, or application can treat the errors except timeout as no error, in all situations, onError would only be called inside ReadClient, only inside Close, we may also update comments for onError, and clearly mention onError is not expected called outside ReadClient.

@yunhanw-google yunhanw-google force-pushed the feature/handle_error_BufferReaderCallback branch from 1003774 to b5e7840 Compare October 31, 2024 18:09
Copy link

PR #36187: Size comparison from c4c9ccf to b5e7840

Full report (1 build for stm32)
platform target config section c4c9ccf b5e7840 change % change
stm32 light STM32WB5MM-DK FLASH 483056 483056 0 0.0
RAM 144844 144844 0 0.0

}

mLastError = DispatchBufferedData(mBufferedPath, StatusIB(), true);
ReturnOnFailure(mLastError);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so this skips calling OnReportEnd and removes the OnError call. But API guarantees either OnReportEnd or OnError, no? I don't understand how this is supposed to work.

That said, in the subscription case OnError means something quite specific which does not match what this code ends up doing if we did call OnError.

So what is the actual behavior we are trying for here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I forgot to push latest change, could you re-review?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again: "what is the actual behavior we are trying for here?" For reads, and for subscriptions (which may want different behaviors, because OnError has very different meanings for them).

src/app/BufferedReadCallback.h Outdated Show resolved Hide resolved
src/app/BufferedReadCallback.h Outdated Show resolved Hide resolved
src/app/BufferedReadCallback.h Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/handle_error_BufferReaderCallback branch 3 times, most recently from 2ad287b to d61033c Compare October 31, 2024 22:15
Copy link

github-actions bot commented Oct 31, 2024

PR #36187: Size comparison from d93f3f6 to a2d22ca

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section d93f3f6 a2d22ca change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1351454 1351454 0 0.0
RAM 104080 104080 0 0.0
bl702 lighting-app bl702+eth FLASH 649058 649058 0 0.0
RAM 25321 25321 0 0.0
bl702+wifi FLASH 826638 826638 0 0.0
RAM 14053 14053 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056298 1056298 0 0.0
RAM 23901 23901 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 976464 976464 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837924 837924 0 0.0
RAM 123628 123628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823696 823696 0 0.0
RAM 125516 125516 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770436 770436 0 0.0
RAM 113984 113984 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754640 754640 0 0.0
RAM 114192 114192 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 627382 627382 0 0.0
RAM 205780 205780 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667126 667126 0 0.0
RAM 205932 205932 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679585 679585 0 0.0
RAM 78684 78684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699437 699437 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699437 699437 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656373 656373 0 0.0
RAM 73752 73752 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616289 616417 128 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635917 636045 128 0.0
RAM 74188 74188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635917 636045 128 0.0
RAM 74188 74188 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635753 635753 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655469 655469 0 0.0
RAM 77236 77236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655469 655469 0 0.0
RAM 77236 77236 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611157 611157 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631009 631009 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631009 631009 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 928556 928556 0 0.0
RAM 160164 160164 0 0.0
BRD4338a FLASH 743288 743288 0 0.0
RAM 233272 233272 0 0.0
window-app BRD4187C FLASH 1018552 1018552 0 0.0
RAM 128260 128260 0 0.0
esp32 all-clusters-app c3devkit DRAM 95328 95328 0 0.0
FLASH 1539912 1539912 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116256 116256 0 0.0
FLASH 1549102 1549102 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2730639 2730639 0 0.0
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6018748 6018748 0 0.0
RAM 523872 523872 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5355990 5355990 0 0.0
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4699494 4699494 0 0.0
RAM 218400 218400 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12900268 12900806 538 0.0
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11028352 11028688 336 0.0
RAM 635400 635400 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11307799 11308337 538 0.0
RAM 584922 584922 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4526546 4526546 0 0.0
RAM 205368 205368 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5238645 5239061 416 0.0
RAM 465432 465432 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5636353 5636353 0 0.0
RAM 228520 228520 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4747914 4747914 0 0.0
RAM 204520 204520 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4374674 4374674 0 0.0
RAM 198240 198240 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4512914 4512914 0 0.0
RAM 202808 202808 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3046061 3046061 0 0.0
RAM 160336 160336 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4116152 4116152 0 0.0
RAM 242936 242936 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5970933 5971397 464 0.0
RAM 596304 596304 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11107629 11108077 448 0.0
RAM 694552 694552 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914996 914996 0 0.0
RAM 143281 143281 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 887572 887572 0 0.0
RAM 141468 141468 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 849060 849060 0 0.0
RAM 142189 142189 0 0.0
nxp contact k32w0+release FLASH 584112 584112 0 0.0
RAM 71044 71044 0 0.0
mcxw71+release FLASH 598648 598648 0 0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 611156 611156 0 0.0
RAM 70436 70436 0 0.0
k32w1+release FLASH 684944 684944 0 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 748480 748480 0 0.0
RAM 67300 67300 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1642828 1642828 0 0.0
RAM 212056 212056 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550356 1550356 0 0.0
RAM 208856 208856 0 0.0
light cy8ckit_062s2_43012 FLASH 1466956 1466956 0 0.0
RAM 200840 200840 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464684 1464684 0 0.0
RAM 225200 225200 0 0.0
qpg lighting-app qpg6105+debug FLASH 662232 662232 0 0.0
RAM 105380 105380 0 0.0
lock-app qpg6105+debug FLASH 620196 620196 0 0.0
RAM 99832 99832 0 0.0
stm32 light STM32WB5MM-DK FLASH 483056 483056 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 684252 684252 0 0.0
RAM 91528 91528 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622362 622362 0 0.0
RAM 50464 50464 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 710278 710254 -24 -0.0
RAM 73804 73804 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628468 628468 0 0.0
RAM 145384 145384 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814816 814816 0 0.0
RAM 100004 100004 0 0.0
tizen all-clusters-app arm unknown 4932 4932 0 0.0
FLASH 1721588 1721588 0 0.0
RAM 90608 90608 0 0.0
chip-tool-ubsan arm unknown 10820 10820 0 0.0
FLASH 18006486 18007990 1504 0.0
RAM 7857312 7857984 672 0.0

@yunhanw-google yunhanw-google force-pushed the feature/handle_error_BufferReaderCallback branch from bcdf800 to 8940d43 Compare November 4, 2024 19:16
Copy link

github-actions bot commented Nov 4, 2024

PR #36187: Size comparison from 50ad31c to fb3289e

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 50ad31c fb3289e4 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1351454 1351502 48 0.0
RAM 104080 104080 0 0.0
bl702 lighting-app bl702+eth FLASH 649058 649062 4 0.0
RAM 25321 25321 0 0.0
bl702+wifi FLASH 826638 826642 4 0.0
RAM 14053 14053 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056298 1056302 4 0.0
RAM 23901 23901 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 976464 976468 4 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837924 837948 24 0.0
RAM 123628 123628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823696 823720 24 0.0
RAM 125516 125516 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770436 770460 24 0.0
RAM 113984 113984 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754640 754664 24 0.0
RAM 114192 114192 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 627382 627430 48 0.0
RAM 205780 205780 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667126 667174 48 0.0
RAM 205932 205932 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679585 679617 32 0.0
RAM 78684 78684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699437 699469 32 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699437 699469 32 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656373 656397 24 0.0
RAM 73752 73752 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616289 616329 40 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635917 635965 48 0.0
RAM 74188 74188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635917 635965 48 0.0
RAM 74188 74188 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635753 635785 32 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655469 655501 32 0.0
RAM 77236 77236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655469 655501 32 0.0
RAM 77236 77236 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611157 611189 32 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631009 631041 32 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631009 631041 32 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 928556 928588 32 0.0
RAM 160164 160164 0 0.0
BRD4338a FLASH 743288 743352 64 0.0
RAM 233272 233272 0 0.0
window-app BRD4187C FLASH 1018552 1018616 64 0.0
RAM 128260 128260 0 0.0
esp32 all-clusters-app c3devkit DRAM 95328 95328 0 0.0
FLASH 1539912 1539926 14 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116256 116256 0 0.0
FLASH 1549102 1549114 12 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2698549 2699097 548 0.0
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 5986488 5987092 604 0.0
RAM 523872 523888 16 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5323796 5324344 548 0.0
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4666208 4666756 548 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12867450 12868374 924 0.0
RAM 584466 584618 152 0.0
chip-tool-ipv6only arm64 unknown 21400 21400 0 0.0
FLASH 11000112 11000528 416 0.0
RAM 635368 635520 152 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11274505 11275429 924 0.0
RAM 584922 585114 192 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4493052 4493600 548 0.0
RAM 205368 205368 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5205317 5206117 800 0.0
RAM 465432 465480 48 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5604977 5604977 0 0.0
RAM 228520 228520 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4715682 4716230 548 0.0
RAM 204520 204520 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4341114 4341662 548 0.0
RAM 198240 198240 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4479516 4480064 548 0.0
RAM 202808 202808 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3013773 3014365 592 0.0
RAM 160336 160336 0 0.0
thermostat-no-ble arm64 unknown 9440 9440 0 0.0
FLASH 4087360 4087696 336 0.0
RAM 242904 242904 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5937829 5938661 832 0.0
RAM 596304 596352 48 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11074605 11075421 816 0.0
RAM 694536 694664 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915000 915032 32 0.0
RAM 143281 143281 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 887560 887596 36 0.0
RAM 141468 141468 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 849064 849064 0 0.0
RAM 142189 142189 0 0.0
nxp contact k32w0+release FLASH 584112 584128 16 0.0
RAM 71044 71044 0 0.0
mcxw71+release FLASH 598656 598680 24 0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 611156 611172 16 0.0
RAM 70436 70436 0 0.0
k32w1+release FLASH 684952 684976 24 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 748488 748512 24 0.0
RAM 67300 67300 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1642828 1642884 56 0.0
RAM 212056 212056 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550356 1550420 64 0.0
RAM 208856 208856 0 0.0
light cy8ckit_062s2_43012 FLASH 1466956 1467020 64 0.0
RAM 200840 200840 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464684 1464732 48 0.0
RAM 225200 225200 0 0.0
qpg lighting-app qpg6105+debug FLASH 662240 662264 24 0.0
RAM 105380 105380 0 0.0
lock-app qpg6105+debug FLASH 620196 620220 24 0.0
RAM 99832 99832 0 0.0
stm32 light STM32WB5MM-DK FLASH 483056 483080 24 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 684316 684318 2 0.0
RAM 91528 91528 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622372 622374 2 0.0
RAM 50464 50464 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 710288 710202 -86 -0.0
RAM 73804 73804 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628478 628480 2 0.0
RAM 145384 145384 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814826 814828 2 0.0
RAM 100004 100004 0 0.0
tizen all-clusters-app arm unknown 4932 4932 0 0.0
FLASH 1721588 1721824 236 0.0
RAM 90608 90616 8 0.0
chip-tool-ubsan arm unknown 10820 10820 0 0.0
FLASH 18006430 18008014 1584 0.0
RAM 7857244 7858024 780 0.0

Copy link

github-actions bot commented Nov 6, 2024

PR #36187: Size comparison from 50ad31c to 81bf7fd

Increases above 0.2%:

platform target config section 50ad31c 81bf7fd change % change
linux fabric-sync debug unknown 4840 4856 16 0.3
FLASH 5205317 5304629 99312 1.9
RAM 465432 466896 1464 0.3
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 50ad31c 81bf7fd change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1351454 1351492 38 0.0
RAM 104080 104080 0 0.0
bl702 lighting-app bl702+eth FLASH 649058 649054 -4 -0.0
RAM 25321 25321 0 0.0
bl702+wifi FLASH 826638 826634 -4 -0.0
RAM 14053 14053 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056298 1056294 -4 -0.0
RAM 23901 23901 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 976464 976460 -4 -0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837924 837940 16 0.0
RAM 123628 123628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823696 823712 16 0.0
RAM 125516 125516 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770436 770452 16 0.0
RAM 113984 113984 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754640 754656 16 0.0
RAM 114192 114192 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 627382 627414 32 0.0
RAM 205780 205780 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667126 667158 32 0.0
RAM 205932 205932 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679585 679601 16 0.0
RAM 78684 78684 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616289 616313 24 0.0
RAM 71644 71644 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635753 635769 16 0.0
RAM 74692 74692 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611157 611173 16 0.0
RAM 68772 68772 0 0.0
light CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699437 699453 16 0.0
RAM 81324 81324 0 0.0
light-switch CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635917 635941 24 0.0
RAM 74188 74188 0 0.0
lock CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655469 655485 16 0.0
RAM 77236 77236 0 0.0
thermostat CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631009 631025 16 0.0
RAM 71412 71412 0 0.0
light CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699437 699453 16 0.0
RAM 81324 81324 0 0.0
light-switch CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635917 635941 24 0.0
RAM 74188 74188 0 0.0
lock CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655469 655485 16 0.0
RAM 77236 77236 0 0.0
thermostat CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631009 631025 16 0.0
RAM 71412 71412 0 0.0
light CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656373 656389 16 0.0
RAM 73752 73752 0 0.0
efr32 lock-app BRD4187C FLASH 928556 928588 32 0.0
RAM 160164 160164 0 0.0
window-app BRD4187C FLASH 1018552 1018616 64 0.0
RAM 128260 128260 0 0.0
lock-app BRD4338a FLASH 743288 743336 48 0.0
RAM 233272 233272 0 0.0
esp32 all-clusters-app c3devkit DRAM 95328 95328 0 0.0
FLASH 1539912 1539910 -2 -0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116256 116256 0 0.0
FLASH 1549102 1549110 8 0.0
IRAM 117039 117039 0 0.0
linux chip-tool-ipv6only arm64 unknown 21400 21400 0 0.0
FLASH 11000112 11002208 2096 0.0
RAM 635368 635368 0 0.0
thermostat-no-ble arm64 unknown 9440 9440 0 0.0
FLASH 4087360 4089424 2064 0.1
RAM 242904 242904 0 0.0
air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2698549 2699079 530 0.0
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 5986488 5991312 4824 0.1
RAM 523872 523872 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5323796 5328534 4738 0.1
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4666208 4670946 4738 0.1
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12867450 12872342 4892 0.0
RAM 584466 584466 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11274505 11279551 5046 0.0
RAM 584922 584986 64 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4493052 4497810 4758 0.1
RAM 205368 205368 0 0.0
fabric-sync debug unknown 4840 4856 16 0.3
FLASH 5205317 5304629 99312 1.9
RAM 465432 466896 1464 0.3
lock-app debug unknown 5344 5344 0 0.0
FLASH 4715682 4720420 4738 0.1
RAM 204520 204520 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4341114 4345852 4738 0.1
RAM 198240 198240 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4479516 4484254 4738 0.1
RAM 202808 202808 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3013773 3014381 608 0.0
RAM 160336 160336 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5937829 5942677 4848 0.1
RAM 596304 596304 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11074605 11079485 4880 0.0
RAM 694536 694536 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5604977 5609185 4208 0.1
RAM 228520 228520 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915000 915020 20 0.0
RAM 143281 143281 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 849064 849064 0 0.0
RAM 142189 142189 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp FLASH 887560 887580 20 0.0
RAM 141468 141468 0 0.0
nxp contact k32w0+release FLASH 584112 584128 16 0.0
RAM 71044 71044 0 0.0
light k32w0+release FLASH 611156 611172 16 0.0
RAM 70436 70436 0 0.0
k32w1+release FLASH 684952 684968 16 0.0
RAM 48776 48776 0 0.0
contact mcxw71+release FLASH 598656 598672 16 0.0
RAM 63144 63144 0 0.0
lock mcxw71+release FLASH 748488 748504 16 0.0
RAM 67300 67300 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1642828 1642860 32 0.0
RAM 212056 212056 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550356 1550404 48 0.0
RAM 208856 208856 0 0.0
light cy8ckit_062s2_43012 FLASH 1466956 1467004 48 0.0
RAM 200840 200840 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464684 1464716 32 0.0
RAM 225200 225200 0 0.0
qpg lighting-app qpg6105+debug FLASH 662240 662256 16 0.0
RAM 105380 105380 0 0.0
lock-app qpg6105+debug FLASH 620196 620212 16 0.0
RAM 99832 99832 0 0.0
stm32 light STM32WB5MM-DK FLASH 483056 483072 16 0.0
RAM 144844 144844 0 0.0
telink lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628478 628472 -6 -0.0
RAM 145384 145384 0 0.0
bridge-app tlsr9258a FLASH 684316 684312 -4 -0.0
RAM 91528 91528 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814826 814296 -530 -0.1
RAM 100004 100004 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622372 622356 -16 -0.0
RAM 50464 50464 0 0.0
tizen all-clusters-app arm unknown 4932 4932 0 0.0
FLASH 1721588 1721792 204 0.0
RAM 90608 90608 0 0.0
chip-tool-ubsan arm unknown 10820 10820 0 0.0
FLASH 18006430 18006774 344 0.0
RAM 7857244 7857472 228 0.0

@yunhanw-google yunhanw-google force-pushed the feature/handle_error_BufferReaderCallback branch 4 times, most recently from b24d465 to ab685c6 Compare November 14, 2024 18:50
@yunhanw-google yunhanw-google force-pushed the feature/handle_error_BufferReaderCallback branch from ab685c6 to 4f893c6 Compare November 14, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants