Enhances some ACL related logging

project-chip · Sep 20, 2024 · b73c370 · b73c370
1 parent 71e3690
commit b73c370
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/protocol/src/interaction/AccessControlManager.ts b/packages/protocol/src/interaction/AccessControlManager.ts
@@ -150,10 +150,14 @@ export class AccessControlManager {
         }
 
         logger.notice(
-            `Failed access control check for ${endpoint.number}/${toHex(clusterId)} and fabricIndex ${session.associatedFabric.fabricIndex}, acl=`,
+            `Failed access control check for ${endpoint.number}/0x${toHex(clusterId)} and fabricIndex ${session.associatedFabric.fabricIndex}, acl=`,
             this.#getAccessControlEntriesForFabric(session.associatedFabric),
+            "with ISD=",
+            this.#getIsdFromMessage(session),
             "granted privileges=",
             grantedPrivileges,
+            "not contains",
+            privilege,
         );
 
         return false;

diff --git a/packages/protocol/src/session/case/CaseServer.ts b/packages/protocol/src/session/case/CaseServer.ts
@@ -126,6 +126,8 @@ export class CaseServer implements ProtocolHandler {
                 `session ${secureSession.id} resumed with ${messenger.getChannelName()} for Fabric ${NodeId.toHexString(
                     fabric.nodeId,
                 )}(index ${fabric.fabricIndex}) and PeerNode ${NodeId.toHexString(peerNodeId)}`,
+                "with CATs",
+                caseAuthenticatedTags,
             );
             resumptionRecord.resumptionId = resumptionId; /* Update the ID */
 
@@ -228,6 +230,8 @@ export class CaseServer implements ProtocolHandler {
                 `session ${secureSession.id} created with ${messenger.getChannelName()} for Fabric ${NodeId.toHexString(
                     fabric.nodeId,
                 )}(index ${fabric.fabricIndex}) and PeerNode ${NodeId.toHexString(peerNodeId)}`,
+                "with CATs",
+                caseAuthenticatedTags,
             );
             await messenger.sendSuccess();