Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PowerTopology implementation and Device type adding logic #1200

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

Apollon77
Copy link
Collaborator

This PR fixes two things (and will also get backported in 0.10.4:

-   Fix: Prevent trying to access PowerTopology attribute which is not always present
-   Fix: Always add the endpoint device types first to the device type list

Copy link

semanticdiff-com bot commented Sep 15, 2024

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Overall, the semantic diff is 31% smaller than the GitHub diff.

Filename Status
✔️ packages/node/src/behaviors/power-topology/PowerTopologyServer.ts 66.67% smaller
✔️ packages/node/src/behaviors/descriptor/DescriptorServer.ts Analyzed

Apollon77 added a commit that referenced this pull request Sep 15, 2024
lauckhart added a commit that referenced this pull request Sep 16, 2024
@Apollon77 Apollon77 marked this pull request as ready for review September 19, 2024 13:33
@mergify mergify bot merged commit 96e0dc9 into main Sep 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants