Sync LevelControl with chip #33204 #848
Draft
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With project-chip/connectedhomeip#33204 the behavior for rate = 0 slightly changes, so this PR brings this in sync.
lauckhart
approved these changes
Apr 27, 2024
|
Re-set to draft because topic is in discussio again in chip repo |
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With project-chip/connectedhomeip#33204 the behavior for rate = 0 slightly changes, so this PR brings this in sync.
@lauckhart Please check and approve, sothat I can merge whenever the otehr PR got merged, because tests will fail afterwards for all PRs (ok and now this PR before the merge too) :-)