Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with C++ SDK E2E Tests #209

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

ivmarkov
Copy link
Contributor

This PR contains three separate commits which are not related to each other - other than the fact that they make us compatible(*) with the C++ SDK E2E Tests framework.

Yay!

Specifically:

  • The E2E tests do log-grepping of a couple of items, so these items need to be named in a special way:
    • The QR code textual representation
    • The mDNS service publishment
  • The E2E tests setup a virtual network which I - for the life of me - couldn't get to broadcast mDNS via IPv4. :-) Therefore, I made the IPv4 broadcasting in our built-in mDNS responder optional. It is fully supported of course, but can now be switched off programatically
  • Weirdly I decided to try the E2E tests first with one of the few clusters we only pretend to support - group_key_management.rs. While there is still work to be done there in future, I've at least fixed the permissions on the attributes, as they did not have any (as the Core Spec BTW is also wrongly documenting these)

(*) To start the tests, we also need support for Matter Basic Commissioning. The support for this is ready, I'm just waiting for this PR to make it through first.

After that, we need two sample applications corresponding to the all-clusters example in Matter as well as another one whose name I don't recall right now.
And of course some hard work to enable more and more tests after that (we need to establish a nightly E2E test CI) and fix all bugs that are coming through.

Copy link

semanticdiff-com bot commented Sep 25, 2024

Review changes with SemanticDiff.

Analyzed 9 of 9 files.

Overall, the semantic diff is 55% smaller than the GitHub diff.

Filename Status
✔️ rs-matter/src/core.rs 32.59% smaller
✔️ rs-matter/src/mdns.rs 32.86% smaller
✔️ rs-matter/src/transport/core.rs 42.05% smaller
✔️ rs-matter/src/pairing/qr.rs 31.46% smaller
✔️ rs-matter/src/mdns/builtin.rs 73.96% smaller
✔️ rs-matter/src/mdns/proto.rs 50.07% smaller
✔️ rs-matter/src/data_model/sdm/group_key_management.rs Analyzed
✔️ examples/onoff_light_bt/src/main.rs 23.37% smaller
✔️ examples/onoff_light/src/main.rs 23.37% smaller

@kedars kedars merged commit ec62ca9 into project-chip:main Sep 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants