Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubebuilder and operator-sdk version #212

Merged
merged 14 commits into from
Jan 12, 2024
Merged

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Oct 11, 2023

  • update the repo structure for the latest kubebuilder (go/v4)
  • rely on operator-sdk v1.33
  • add basic readiness/liveness probes

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c930a50) 85.12% compared to head (47f8357) 85.12%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          13       13           
  Lines        2730     2730           
=======================================
  Hits         2324     2324           
  Misses        325      325           
  Partials       81       81           
Flag Coverage Δ
unittests 85.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/collector/collector.go 86.76% <ø> (ø)
internal/collector/prometheus.go 96.64% <ø> (ø)
internal/collector/report.go 80.32% <ø> (ø)
internal/collector/types.go 100.00% <ø> (ø)
...nternal/controller/kokumetricsconfig_controller.go 85.98% <ø> (ø)
internal/controller/prometheus.go 93.52% <ø> (ø)
internal/crhchttp/config.go 93.02% <ø> (ø)
internal/crhchttp/http_cloud_dot_redhat.go 0.00% <ø> (ø)
internal/dirconfig/dirconfig.go 96.15% <ø> (ø)
internal/packaging/packaging.go 79.58% <ø> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c930a50...47f8357. Read the comment docs.

@maskarb maskarb force-pushed the update-kubebuilder branch from e372142 to 52e13fe Compare October 16, 2023 22:55
@maskarb maskarb force-pushed the update-kubebuilder branch from 52e13fe to 7cef696 Compare October 16, 2023 22:58
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

89.1% 89.1% Coverage
3.1% 3.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

87.9% 87.9% Coverage
3.0% 3.0% Duplication

@maskarb maskarb changed the title Update kubebuilder and Go update kubebuilder and operator-sdk version Jan 11, 2024
@maskarb maskarb marked this pull request as ready for review January 12, 2024 14:49
samdoran
samdoran previously approved these changes Jan 12, 2024
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a good idea to create a requirements.txt file in scripts/ since packaging is required. It would just be the one requirement of packaging==23.2.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

14 New issues
0 Security Hotspots
87.9% Coverage on New Code
2.9% Duplication on New Code

See analysis details on SonarCloud

@maskarb maskarb merged commit 9b0294e into main Jan 12, 2024
7 checks passed
@maskarb maskarb deleted the update-kubebuilder branch January 12, 2024 15:58
@maskarb maskarb mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants