-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kubebuilder and operator-sdk version #212
Conversation
maskarb
commented
Oct 11, 2023
•
edited
Loading
edited
- update the repo structure for the latest kubebuilder (go/v4)
- rely on operator-sdk v1.33
- add basic readiness/liveness probes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 13 13
Lines 2730 2730
=======================================
Hits 2324 2324
Misses 325 325
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
e372142
to
52e13fe
Compare
52e13fe
to
7cef696
Compare
SonarCloud Quality Gate failed. 0 Bugs 89.1% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be a good idea to create a requirements.txt
file in scripts/
since packaging
is required. It would just be the one requirement of packaging==23.2
.
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 14 New issues |