Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored webpack to work with Insights proxy #1975

Merged
merged 1 commit into from
May 27, 2021
Merged

Refactored webpack to work with Insights proxy #1975

merged 1 commit into from
May 27, 2021

Conversation

dlabrecq
Copy link
Contributor

Refactored webpack config to work with the Insights (Docker) proxy.

@dlabrecq dlabrecq requested a review from ddonahue007 May 27, 2021 16:34
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021 •
edited
Loading

Codecov Report

Merging #1975 (e383af9) into master (8321493) will not change coverage.
The diff coverage is n/a.

❗ Current head e383af9 differs from pull request most recent head 33ec3e3. Consider uploading reports for the commit 33ec3e3 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1975   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files         372      372           
  Lines        6829     6829           
  Branches     1464     1464           
=======================================
  Hits         4864     4864           
  Misses       1941     1941           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8321493...33ec3e3. Read the comment docs.

@dlabrecq dlabrecq changed the title Refactored webpack config to work with the Insights proxy for Docker Refactored webpack config to work with the Insights proxy May 27, 2021
@dlabrecq dlabrecq changed the title Refactored webpack config to work with the Insights proxy Refactored webpack to work with Insights proxy May 27, 2021
@dlabrecq dlabrecq merged commit 39f4f62 into project-koku:master May 27, 2021
ddonahue007
ddonahue007 reviewed May 27, 2021
View reviewed changes
Copy link
Contributor

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabrecq dlabrecq deleted the insights-proxy branch June 9, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddonahue007 ddonahue007 ddonahue007 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlabrecq @codecov-commenter @ddonahue007