-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable build cache and HMR #2656
Conversation
@dlabrecq ok I was able to get it working. The issues is with direct default exports. See: https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/main/docs/TROUBLESHOOTING.md#edits-always-lead-to-full-reload This diff made it work for me:
|
It is possible that making changes to some nested components that follow the same pattern might cause a full refresh. But making sure the function is not directly exported as a default module will fix the potential issue. |
Codecov Report
@@ Coverage Diff @@
## main #2656 +/- ##
========================================
Coverage 65.70% 65.70%
========================================
Files 451 451
Lines 8918 8918
Branches 2081 1937 -144
========================================
Hits 5860 5860
Misses 3055 3055
Partials 3 3 Continue to review full report at Codecov.
|
Thank you for the help, Martin. I wasn't able to see HMR working with the diffs, so I temporarily disabled the feature. Just going to use the build cache for now. I created an issue to refactor our unnamed default exports in order to enable HMR separately. |
Enable build cache and HMR.
https://issues.redhat.com/browse/COST-3220