[COST-4877] Report correct PostgreSQL version #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdoran
added
the
smoke-tests
The version string digits changed after PostgreSQL 9. Update the version string parsing to work with both version number schemas. Change get_pg_engine_version method to return a string instead of list of ints. This makes it easier for the caller. This will need to be updated when PostgreSQL goes above version 99. - Use a simpler SQL command to get the version string from the database - Remove unecessary use of a global - Add more test cases
samdoran
force-pushed
the
fix-psql-version
branch
from
a5ead41 to
a28fe2c
Compare
maskarb
reviewed
Apr 4, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5019 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 377 377
Lines 31322 31321 -1
Branches 3713 3711 -2
=====================================
+ Hits 29479 29483 +4
+ Misses 1174 1170 -4
+ Partials 669 668 -1 |
maskarb
reviewed
Apr 4, 2024
samdoran
force-pushed
the
fix-psql-version
branch
from
be66445 to
90ac78e
Compare
maskarb
reviewed
Apr 4, 2024
samdoran
force-pushed
the
fix-psql-version
branch
3 times, most recently
from
66c1bcf to
ae96c8e
Compare
maskarb
reviewed
Apr 4, 2024
The output seems to vary more than server_version_num but is far easier to parse.
samdoran
force-pushed
the
fix-psql-version
branch
from
ae96c8e to
cde48d1
Compare
maskarb
approved these changes
Apr 8, 2024
|
@samdoran can we link this to a JIRA please. |
samdoran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4877
Description
The version string digits changed after PostgreSQL 9. Update the version string parsing to work with both version number schemas.
Change
get_pg_engine_versionmethod to return a string instead of list of ints. This makes it easier for the caller.Use a simpler SQL command to get the version string from the database
Remove unecessary use of a global
Add more test cases
Testing
Release Notes