Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5565] - Fix bug in old tag matching logic #5429

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Dec 18, 2024

Jira Ticket

COST-5565

Description

This change will remove the line to lower tag key/values in the cloud dataframe before trying to match them with OCP tags. Tag matching is case sensitive and setting tags to lower inadvertently prevents us matching.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Load ocp on cloud data with tag matching data (make sure to use upper case tags)
  4. See data is matched by tag correctly

Checkout main and do the same:
see that we fail to match on tags because app != APP

Note:
This was found while investigating differences in cost from the new managed tables flow. Cost didnt match because the old flow was not correlating tag costs as expected.

Release Notes

  • proposed release note
* [COST-5565](https://issues.redhat.com/browse/COST-5565) Fix old tag matching logic

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Dec 18, 2024
@lcouzens lcouzens requested review from a team as code owners December 18, 2024 18:20
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (94dbc09) to head (999a395).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5429   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files        371     371           
  Lines      31542   31542           
  Branches    3378    3378           
=====================================
+ Hits       29698   29699    +1     
  Misses      1198    1198           
+ Partials     646     645    -1     

@lcouzens
Copy link
Contributor Author

/retest

2 similar comments
@lcouzens
Copy link
Contributor Author

/retest

@lcouzens
Copy link
Contributor Author

/retest

@lcouzens lcouzens merged commit 0babb2a into main Dec 19, 2024
14 checks passed
@lcouzens lcouzens deleted the COST-5565-fix-lower branch December 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants