[COST-5565] - Fix bug in old tag matching logic #5429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-5565
Description
This change will remove the line to lower tag key/values in the cloud dataframe before trying to match them with OCP tags. Tag matching is case sensitive and setting tags to lower inadvertently prevents us matching.
Testing
Checkout main and do the same:
see that we fail to match on tags because
app
!=APP
Note:
This was found while investigating differences in cost from the new managed tables flow. Cost didnt match because the old flow was not correlating tag costs as expected.
Release Notes