Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated docs for Rust SDK available #246

Closed
daviddrysdale opened this issue Oct 4, 2019 · 11 comments
Closed

Make generated docs for Rust SDK available #246

daviddrysdale opened this issue Oct 4, 2019 · 11 comments
Assignees
Labels

Comments

@daviddrysdale
Copy link
Contributor

Having improved the SDK doc comments, it would be nice if the cargo doc generated docs were online somewhere.

Possible options:

I'd lean towards the last of these, with the generated docs stored in an sdk/ top-level directory so that it's possible to have a top-level index.html file that redirects to sdk/oak/index.html (because the top directory from cargo doc on the rust/ directory doesn't have an index.html file in it).

Example of how this would look here: https://daviddrysdale.github.io/oak

(Regardless of which mechanism we adopt, we should add something like a CI check to keep the generated docs up to date…)

@daviddrysdale daviddrysdale self-assigned this Oct 4, 2019
@daviddrysdale
Copy link
Contributor Author

@tiziano88 @michael-kernel-sanders @anghelcovici : thoughts/preferences?

@anghelcovici
Copy link
Contributor

I like the example (hence, the last option), maybe we can use github actions to sync that?

@daviddrysdale
Copy link
Contributor Author

Docs are now up at https://project-oak.github.io/oak. Leaving this issue open to cover setting some automated system for keeping them in sync with master.

@tiziano88
Copy link
Collaborator

Awesome! Could you add a link to that somewhere in the existing docs?

@daviddrysdale
Copy link
Contributor Author

Links to generated docs added in #257

@daviddrysdale
Copy link
Contributor Author

One wrinkle that will apply to any auto-regeneration system: rustdoc does not produce deterministic output, so it will not be safe to run a script on every commit and commit to gh-pages if anything has changed.

@tiziano88
Copy link
Collaborator

Is there anything left to do for this, apart from the auto-generation?

@daviddrysdale
Copy link
Contributor Author

daviddrysdale commented Apr 20, 2020

Still to do:

@daviddrysdale
Copy link
Contributor Author

Now #866 is in, might as well close this and defer to #765 for what's left.

@daviddrysdale
Copy link
Contributor Author

Comment above about non-deterministic output looks like it still applies.

tiziano88 added a commit to tiziano88/oak that referenced this issue Apr 20, 2020
Avoid committing if there is no change compared to the previous version,
to keep history clean.

Ref project-oak#246
tiziano88 added a commit to tiziano88/oak that referenced this issue Apr 20, 2020
Avoid committing if there is no change compared to the previous version,
to keep history clean.

Ref project-oak#246
tiziano88 added a commit to tiziano88/oak that referenced this issue Apr 20, 2020
Avoid committing if there is no change compared to the previous version,
to keep history clean.

Ref project-oak#246
tiziano88 added a commit to tiziano88/oak that referenced this issue Apr 20, 2020
Avoid committing if there is no change compared to the previous version,
to keep history clean.

Ref project-oak#246
tiziano88 added a commit to tiziano88/oak that referenced this issue Apr 20, 2020
Avoid committing if there is no change compared to the previous version,
to keep history clean.

Ref project-oak#246
tiziano88 added a commit to tiziano88/oak that referenced this issue Apr 20, 2020
Avoid committing if there is no change compared to the previous version,
to keep history clean.

Ref project-oak#246
tiziano88 added a commit that referenced this issue Apr 21, 2020
Avoid committing if there is no change compared to the previous version,
to keep history clean.

Ref #246
@daviddrysdale
Copy link
Contributor Author

The doc generation has been deterministic for a while, so closing this in favour of #765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants