-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make generated docs for Rust SDK available #246
Comments
@tiziano88 @michael-kernel-sanders @anghelcovici : thoughts/preferences? |
I like the example (hence, the last option), maybe we can use github actions to sync that? |
Docs are now up at https://project-oak.github.io/oak. Leaving this issue open to cover setting some automated system for keeping them in sync with |
Awesome! Could you add a link to that somewhere in the existing docs? |
Links to generated docs added in #257 |
One wrinkle that will apply to any auto-regeneration system: rustdoc does not produce deterministic output, so it will not be safe to run a script on every commit and commit to |
Is there anything left to do for this, apart from the auto-generation? |
Still to do:
|
Comment above about non-deterministic output looks like it still applies. |
Avoid committing if there is no change compared to the previous version, to keep history clean. Ref project-oak#246
Avoid committing if there is no change compared to the previous version, to keep history clean. Ref project-oak#246
Avoid committing if there is no change compared to the previous version, to keep history clean. Ref project-oak#246
Avoid committing if there is no change compared to the previous version, to keep history clean. Ref project-oak#246
Avoid committing if there is no change compared to the previous version, to keep history clean. Ref project-oak#246
Avoid committing if there is no change compared to the previous version, to keep history clean. Ref project-oak#246
Avoid committing if there is no change compared to the previous version, to keep history clean. Ref #246
The doc generation has been deterministic for a while, so closing this in favour of #765 |
Having improved the SDK doc comments, it would be nice if the
cargo doc
generated docs were online somewhere.Possible options:
./docs/sdk/
: On its own this doesn't help much, because GitHub doesn't serve up .html files as HTML, just .md files. However…./docs/sdk/
and turn on GitHub pages fordocs/
onmaster
: This would make the docs visible at https://project-oak.github.io/oak/sdk/; however, the Markdown files indocs/
would show up at https://project-oak.github.io/oak/ but would not render properly.gh-pages
orphan branch.I'd lean towards the last of these, with the generated docs stored in an
sdk/
top-level directory so that it's possible to have a top-levelindex.html
file that redirects tosdk/oak/index.html
(because the top directory fromcargo doc
on therust/
directory doesn't have anindex.html
file in it).Example of how this would look here: https://daviddrysdale.github.io/oak
(Regardless of which mechanism we adopt, we should add something like a CI check to keep the generated docs up to date…)
The text was updated successfully, but these errors were encountered: