Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate target dir when compiling Wasm code #1044

Merged
merged 1 commit into from
May 28, 2020

Conversation

tiziano88
Copy link
Collaborator

@tiziano88 tiziano88 commented May 28, 2020

It should help with #971, until a more proper solution is in place.

@tiziano88 tiziano88 force-pushed the tzn_target_dir branch 2 times, most recently from f5c2ae9 to ed1f318 Compare May 28, 2020 18:00
@tiziano88 tiziano88 requested a review from rbehjati May 28, 2020 18:01
@tiziano88 tiziano88 marked this pull request as ready for review May 28, 2020 18:01
Copy link
Contributor

@rbehjati rbehjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It should help with project-oak#971, until a more proper solution is in place.
@tiziano88 tiziano88 merged commit 9f5d57f into project-oak:master May 28, 2020
@tiziano88 tiziano88 deleted the tzn_target_dir branch May 28, 2020 22:16
@github-actions
Copy link

Reproducibility Index:

d9ab9379c2397795e5ec2cbd7b562675bdd58732fff573dfffd07e4c80b1b25d  ./examples/target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
a76f8259ff7200f4c459dd9e071914b2d874cd42677fa964f47f2f1367b80f00  ./examples/target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
93c63ff47b47ead838ca5144547b29463d01d699759b44cc599a3cf70adb9f53  ./examples/target/wasm32-unknown-unknown/release/aggregator.wasm
5c468b6295f481af8b4b5758e3c67ec5523ecbac99f72a88cf9d43a4a7747274  ./examples/target/wasm32-unknown-unknown/release/chat.wasm
dda50d2185ae1e9c7e9c5cded711823b6952d277ac8f38290eee4093763a67de  ./examples/target/wasm32-unknown-unknown/release/hello_world.wasm
cb2de9fc1d3af6d4d80b2441409a8b6888b892654e8769253de535cceea78135  ./examples/target/wasm32-unknown-unknown/release/machine_learning.wasm
ffacb1b30bb721d235df5fb648017c8dfaacbb7e318993d16f14893b07293845  ./examples/target/wasm32-unknown-unknown/release/private_set_intersection.wasm
7ceb8a30ec9bafb671ba15f886a684ec0776c1e00c3bf3ba269a627e938feba3  ./examples/target/wasm32-unknown-unknown/release/running_average.wasm
47b81f9c85ad5dfeacb389a6a4a1beb0baaeac828ac002ccd0b04dba8fa07c45  ./examples/target/wasm32-unknown-unknown/release/translator.wasm
141f915fb198d9ce7a2c1e97115d9810c9253d3d2b7d34eddaad0fb32b77c9d6  ./target/x86_64-unknown-linux-musl/release/oak_loader

Reproducibility Index diff:

diff --git a/reproducibility_index b/reproducibility_index
index 039b26b..dbc90a7 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -1,10 +1,10 @@
-165306babbdaf0d7c8cddfbae0ef95a8bee9090b1664d036a39df69299682b7f  ./target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
-a76f8259ff7200f4c459dd9e071914b2d874cd42677fa964f47f2f1367b80f00  ./target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
-bc01acbfb3f9ef2fa8ad962f9dd5ace34c37e9afd30b6b6b9ba4e92a5512f7f9  ./target/wasm32-unknown-unknown/release/aggregator.wasm
-e2124e9da19d018e783ade27569392627804d781c0e8f44c46dd0dfc43ba48ca  ./target/wasm32-unknown-unknown/release/chat.wasm
-b3d1f58ffcb4ccdb10f4d7d2914e24952ae44d5259520ba949167bdc459435b4  ./target/wasm32-unknown-unknown/release/hello_world.wasm
-cb2de9fc1d3af6d4d80b2441409a8b6888b892654e8769253de535cceea78135  ./target/wasm32-unknown-unknown/release/machine_learning.wasm
-c10517881a33f4b631c31f0e511c1944b946b2ad133dbccee6f1dddba36c7705  ./target/wasm32-unknown-unknown/release/private_set_intersection.wasm
-7b1ff17fc70489273da8b55b01dd4cfe496b96c56faefe0fe535e027d27ea7dc  ./target/wasm32-unknown-unknown/release/running_average.wasm
-20194a33031ff9e3dcce7b6e2289a50377f1418aee48bd6463f5118640ce6140  ./target/wasm32-unknown-unknown/release/translator.wasm
+d9ab9379c2397795e5ec2cbd7b562675bdd58732fff573dfffd07e4c80b1b25d  ./examples/target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
+a76f8259ff7200f4c459dd9e071914b2d874cd42677fa964f47f2f1367b80f00  ./examples/target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
+93c63ff47b47ead838ca5144547b29463d01d699759b44cc599a3cf70adb9f53  ./examples/target/wasm32-unknown-unknown/release/aggregator.wasm
+5c468b6295f481af8b4b5758e3c67ec5523ecbac99f72a88cf9d43a4a7747274  ./examples/target/wasm32-unknown-unknown/release/chat.wasm
+dda50d2185ae1e9c7e9c5cded711823b6952d277ac8f38290eee4093763a67de  ./examples/target/wasm32-unknown-unknown/release/hello_world.wasm
+cb2de9fc1d3af6d4d80b2441409a8b6888b892654e8769253de535cceea78135  ./examples/target/wasm32-unknown-unknown/release/machine_learning.wasm
+ffacb1b30bb721d235df5fb648017c8dfaacbb7e318993d16f14893b07293845  ./examples/target/wasm32-unknown-unknown/release/private_set_intersection.wasm
+7ceb8a30ec9bafb671ba15f886a684ec0776c1e00c3bf3ba269a627e938feba3  ./examples/target/wasm32-unknown-unknown/release/running_average.wasm
+47b81f9c85ad5dfeacb389a6a4a1beb0baaeac828ac002ccd0b04dba8fa07c45  ./examples/target/wasm32-unknown-unknown/release/translator.wasm
 141f915fb198d9ce7a2c1e97115d9810c9253d3d2b7d34eddaad0fb32b77c9d6  ./target/x86_64-unknown-linux-musl/release/oak_loader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants