Improve logging of gRPC request handling #1084
Merged
+17
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiziano88
added
the
blocked
|
This is now blocked by #865, since the actual has of the wasm module is different on my machine and on cloud build. |
tiziano88
force-pushed
the
tzn_aggregator_wasm_hash
branch
6 times, most recently
from
652eeb7 to
dfa7a2b
Compare
tiziano88
changed the title
tiziano88
removed
the
blocked
The main change is that we log one info entry for each gRPC request, including details of its label, so that it's possible to debug label mismatch issues. Also do not log the contents of the request, only its size, and the client IP address (though this does not seem to work reliably yet).
tiziano88
force-pushed
the
tzn_aggregator_wasm_hash
branch
from
dfa7a2b to
ca307e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is that we log one info entry for each gRPC request,
including details of its label, so that it's possible to debug label
mismatch issues.
Also do not log the contents of the request, only its size, and the
client IP address (though this does not seem to work reliably yet).