Vendor and patch Prost #1200
Closed
Vendor and patch Prost #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch adds functionality to prost so we can pass handles in protobufs.
Taken from https://github.com/danburkert/prost at commit 80256277997975948d257faf3f35c2890bf12787 ("prost-build: fix compilation error when using --no-default-features"). Full repo with prost/prost-build/third_party removed. To reproduce this commit, run `./scripts/vendor_prost.sh -c`. Tests are passing with `PROTOC=/usr/bin/protoc cargo test`. Note the PROTOC environment variable must be set because the bundled protobuf has been removed.
patch file: `third_party/prost-0001-Patch-to-generate-typesafe-Sender-and-Receiver.patch` To reproduce this commit, run `./script/vendor_prost.sh`.
|
@daviddrysdale @tiziano88 as mentioned in #1108 (comment) |
|
Closing this in favor of #1199. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendors https://github.com/danburkert/prost into
third_partyand applies a patch that will help pass handles in protobuf messages. for context, see #673.This PR also includes a script that can be used to vendor prost and apply the patch to make it easier to maintain.
This is the first of a set of PRs that together provide the same functionality as #1108, but introduced in smaller portions.
Checklist
Cloudbuild
cover any TODOs and/or unfinished work.
construction.