Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bare-metal build break #2804

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

conradgrobler
Copy link
Collaborator

@conradgrobler conradgrobler commented May 4, 2022

Since Wasm support has been added to the bare-metal runtime, the build fails at link time. This is because Wasmi relies on floating point features that was not supported.

This is fixed by:

@conradgrobler conradgrobler requested a review from a team as a code owner May 4, 2022 08:37
@conradgrobler conradgrobler requested review from rbehjati and andrisaar and removed request for a team May 4, 2022 08:37
@conradgrobler conradgrobler merged commit 17896ef into project-oak:main May 4, 2022
@conradgrobler conradgrobler deleted the hard-float branch May 4, 2022 14:33
@github-actions
Copy link

github-actions bot commented May 4, 2022

Reproducibility Index:

eadcb5aab7eb4ee0d91e178868ca59a1524c4ed7a14d67ac5e99e5683d08871d  ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_base
6358962ad071a3982c98296d56b6a6cf0c37e2f46cf22c4d2a2b99ed10eb4e71  ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_unsafe

Reproducibility Index diff:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants