Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf files available for generating clients #32

Closed
tnickelsen opened this issue Jun 7, 2023 · 2 comments
Closed

Protobuf files available for generating clients #32

tnickelsen opened this issue Jun 7, 2023 · 2 comments

Comments

@tnickelsen
Copy link
Contributor

tnickelsen commented Jun 7, 2023

Description

Protobuf files are used for gRPC contract for server and client. Right now .proto files are implemented by the server, but clients needs to implement them as well in order to call the server. Thus the .proto files needs to be distributed/availble to/fer server and clients.

One approach is using references to tags in Github repository.
Another is via nuget. See links:

Acceptance criteria

  • Documentation updated with how to generate a client

Scope limit

Solution plan

@duizer duizer changed the title Protobuf files are published nia nuget Protobuf files available for generating clients Jun 8, 2023
@duizer
Copy link
Contributor

duizer commented Jun 8, 2023

Martin prefers a solution where client projects refer to the protobuf-files in tags in this github repo

@MartinSchmidt
Copy link
Member

Yes, I think it would be best for consuming applications to reference the raw protobuf files, this ensures our documentation and examples are sufficient for all client languages. If we begin creating nuget packages, then dotnet clients might be easier, but other languages might be harder, since we might not be as focused on proper documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants