-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC JSON transcoding - msbuild includes proto dependencies #44999
Conversation
@jtattermusch This is what I discussed in our sync. It works well. |
@JamesNK awesome! |
…tically include external dependencies
1619af4
to
31b3af5
Compare
Answered offline, but for others -- we can freely use third party code that is permissively licensed (at least Apache/MIT) but they must appear in a TPN and that TPN must end up packaged in the relevant packages/installers. I know there is some debt wrt the installer/shared frameworks (dotnet/runtime#74779) but our individual packages should be inspected to ensure their TPN goes in. |
31b3af5
to
0f0f714
Compare
This is excellent! Can it be back-ported to 7.0 so we don't have to wait until .NET 8.0? ;p |
Hi @zidad. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Any news to downgrade it to .net 6.0 ? Or how do i do it in .net 6 try so much ways, but it doesnt work at all |
Hi @tobiashoeft. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
@tobiashoeft Yeah I also tried to back port this feature to our own .net 7.0 nuget package but didn't manage to get it working unfortunately. |
Hi @zidad. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Fixes #43376
This PR changes the gRPC JSON transcoding package to:
Microsoft.AspNetCore.Grpc.JsonTranscoding.targets
to the NuGet package. It automatically add proto dependencies toGrpc.Tooling
protoc compilation.<IncludeHttpRuleProtos>true</IncludeHttpRuleProtos>
to control adding dependencies. Defaults to false.This change eliminates the biggest obstacle to setting up gRPC JSON transcoding: acquiring the proto files and placing them in the right location. Now a dev just sets
IncludeHttpRuleProtos
to true in the csproj 🥳 🎈 🎉@danmoseley The proto files are under Apache license to Google. I think the entries in https://github.com/dotnet/aspnetcore/blob/main/src/Grpc/THIRD-PARTY-NOTICES covers that license already. Is there other reaction to third-party code that needs to happen?