Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to Symfony 6.4, with Symfony Flex #201

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

tchapuis
Copy link

@tchapuis tchapuis commented Dec 17, 2024

Hello and thank you for your project.

At my work, we installed it and we are using it very intensively. We had no problems so far but I wanted to update it.

Here I am with this very long update to Symfony 6.4. There is a couple of important things to note :

  • I had to drop the support for PHP 8.1 because composer/satis on branch dev-main require symfony/console to version 7.1, which is not compatible with PHP 8.1
  • I moved everything out of the bundle folder structure to the Symfony Flex app folder structure. I kept the Playboom namespace.
  • I tried to not touch any logic but making tests work again was a pain

Feel free to ask any questions regarding this PR 😃

@ramunasd
Copy link
Collaborator

Thanks a lot! I will review and let you know if something is missing.
BTW, have you tested it somewhere?

@tchapuis
Copy link
Author

I tested it on my local machine, with both sample data from the project and real composer package, e.g. symfony/console. Everything seems to work correctly.

I had problems testing it on Docker but maybe my setup is not right.

@ramunasd
Copy link
Collaborator

Seems there is one issue with satis template and recent twig version

Deprecation Notice: Since twig/twig 3.12: Character "D" should not be escaped; the "\" character is ignored in Twig 3 but will not be in Twig 4. Please remove the extra "\" character at position 2 in "index.html.twig" at line 36. in /var/www/html/vendor/symfony/deprecation-contracts/function.php:25

I could not successfully build cache using web console, while CLI tool did the job.

@ramunasd
Copy link
Collaborator

Since configuration files are changed, existing setups won't be able upgrade without additional efforts. This PR is introducing breaking changes, which means we can release it as next major version and we need upgrade notes 🤔

@tchapuis
Copy link
Author

Since configuration files are changed, existing setups won't be able upgrade without additional efforts. This PR is introducing breaking changes, which means we can release it as next major version and we need upgrade notes 🤔

Parameters and .env are untouched by this PR but any other custom configuration will impact people for sure.

@tchapuis
Copy link
Author

Seems there is one issue with satis template and recent twig version

Deprecation Notice: Since twig/twig 3.12: Character "D" should not be escaped; the "\" character is ignored in Twig 3 but will not be in Twig 4. Please remove the extra "\" character at position 2 in "index.html.twig" at line 36. in /var/www/html/vendor/symfony/deprecation-contracts/function.php:25

I could not successfully build cache using web console, while CLI tool did the job.

This is a problem with the satis template, so I opened a PR on this project : composer/satis#947

@ramunasd
Copy link
Collaborator

seems fix is already landed and this PR can be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants