Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GC adapter hot-swapping. No more "my polling rate is >10k".
Demo video
Currently requires 100 error responses to poll requests in a row to consider the adapter has been permanently disconnected.
The disconnection of the adapter if comms died is done by a non-polling thread. The polling thread writes down that the adapter is MIA, and this is acted upon when: a pad status read happens / a polling rate update happens in the relevant WX window / when that window is opened.
I don't know if pad status = full zero i.e sticks left/down is a great answer to an adapter disconnecting mid-match. Perhaps centered pad state with a message would be better...
Also I don't know if this should go to release/2.3.0 or master but for diff sake I set it to release/2.3.0, can be rebased later.