New chat config options #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious options to check for Enable Chat first. + Moved Auto disabled chat message to ExiDeviceSlippi instead
…ed, get it?) - Fix bug preventing message Id for Chat is Disabled when doing chat message validations.
|
<3 You da best. Do you think that having the option called |
I think it would be yeah, not my call anyway lol. I don't really mind, so just let me know. @NikhilNarayana |
altf4
pushed a commit
to altf4/Ishiiruka
that referenced
this pull request
Dec 21, 2021
* Change config pane option to be a dropdown and refactor usages of previous options to check for Enable Chat first. + Moved Auto disabled chat message to ExiDeviceSlippi instead * Fix logic that checks if Chat is Enabled (I missed a break so I crashed, get it?) - Fix bug preventing message Id for Chat is Disabled when doing chat message validations. * Run formatter * make map static * wording, variable name, and formatting updates Co-authored-by: Nikhil Narayana <nikhil.narayana@live.com>
jordan-zilch
pushed a commit
to jordan-zilch/Ishiiruka
that referenced
this pull request
May 17, 2022
* Change config pane option to be a dropdown and refactor usages of previous options to check for Enable Chat first. + Moved Auto disabled chat message to ExiDeviceSlippi instead * Fix logic that checks if Chat is Enabled (I missed a break so I crashed, get it?) - Fix bug preventing message Id for Chat is Disabled when doing chat message validations. * Run formatter * make map static * wording, variable name, and formatting updates Co-authored-by: Nikhil Narayana <nikhil.narayana@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Options
On the Configuration under Slippi Tab you can now find new options for Quick Chat
I won't explain them ;)
Bug fixes
With this PR the "Your opponent has chat disabled" message was being falsely filtered out, so I added it back in.
People will now be able to see the message again if their opponent had chat disabled (teams behavior is still preserved).