refactor chat and add configurable chat messages #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make MxDt reference our CSS methods
…rly converted and rendered in-game.
…r/quickchat # Conflicts: # Data/Sys/GameFiles/GALE01/SlippiCSS.dat # Data/Sys/GameSettings/GALE01r2.ini # Data/Sys/GameSettings/GALJ01r2.ini
NikhilNarayana
changed the title
NikhilNarayana
approved these changes
Jun 7, 2023
rapito
added a commit
to rapito/Ishiiruka
that referenced
this pull request
Aug 31, 2023
* update asm and c codeset - Make MxDt reference our CSS methods * chore: update asm codeset * update codeset and fix default debug command * chore: update codeset chat refactor * update codeset * Update codeset * Update codeset * chore: update asm and c codesets project-slippi/slippi-ssbm-asm#106 * Use iconv fallbacks on macos so special and SJIS characters are properly converted and rendered in-game. * build codesets * start support for configured chat messages * use test default messages * receive chat messages from mm service * feature: show configured messages in preview * chore: clean comments and loggers * fix: ifdef iconvctl for mac only * chore: try to get linux building * chore: use nullptr instead of NULL * chore: ifdef attempt 3 for linux * chore: dont call functions that dont exist * swap elif for else * undo template name move * chore: update code lists --------- Co-authored-by: Jas Laferriere <Fizzi36@gmail.com> Co-authored-by: Nikhil Narayana <nikhil.narayana@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes
¥is the only one that is not properly converted from UTF to SJIS by dolphin (on macos), however the game and chat handle it if the proper bytes are passed back to it.