Attempt to improve backtraces from the Rust side. #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We auto-set `RUST_BACKTRACE=full` in the logger initialization, since that's the first thing on the Rust side that ever gets initialized. - Added a `.cargo/config.toml` that passes an extra flag to the compiler that should retain unwind tables, which are helpful for getting backtraces
JLaferri
approved these changes
Aug 11, 2023
rapito
pushed a commit
to rapito/Ishiiruka
that referenced
this pull request
Aug 31, 2023
- We auto-set `RUST_BACKTRACE=full` in the logger initialization, since that's the first thing on the Rust side that ever gets initialized. - Added a `.cargo/config.toml` that passes an extra flag to the compiler that should retain unwind tables, which are helpful for getting backtraces Co-authored-by: Jas Laferriere <Fizzi36@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to improve backtraces from the Rust side.
Auto-set
RUST_BACKTRACE=fullin the logger initialization, sincethat's the first thing on the Rust side that ever gets initialized.
Added a
.cargo/config.tomlthat passes an extra flag to the compilerthat should retain unwind tables, which are helpful for getting
backtraces.
There may be other things we want to do here but figured this is a decent start/this PR could be a tracking issue for testing.