[game-reporter] Move completion network call into a background thread #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this can be refactored into something nicer as this grows
JLaferri
approved these changes
Aug 14, 2023
rapito
pushed a commit
to rapito/Ishiiruka
that referenced
this pull request
Aug 31, 2023
…project-slippi#398) * Move completion network call into its own background thread for now - this can be refactored into something nicer as this grows * fix: arg order on report completion --------- Co-authored-by: Jas Laferriere <Fizzi36@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extra background thread in the reporter that completion calls get routed to. There are some potentially cleaner approaches I want to look into for ensuring this kind of thing is less code to do as things grow, but this should hit the immediate issue of any potential hangs and is still fairly well self contained.