Record instance info for Fighters/Items #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a fighter starts an action a new 16 bit 'instance' value is incremented and stored in the fighter at offset 0x2088. Additionally, when a fighter throws/spawns an item/projectile, that item inherits that fighter's instance at offset 0xDA8. When a fighter is hit by a move/item, the instance value of the attacker/item is copied to the victim fighter at offset 0x18EC.
This PR adds the fighter instance & instance_hit_by fields to post frame update and the item instance field to the item update. These fields can be used to better track hits in doubles because
lastHitBy
field is unreliable (project-slippi/slippi-js#71).Notes:
Short example replay 1v1 against CPU:
Game_20230316T213900.zip