Skip to content

Commit

Permalink
test: Fix test failure due to .coverage changing during tar creation. (
Browse files Browse the repository at this point in the history
…#557)

This seems to be a transient failure, but is legitimate issue.

When coverage binary is being used, this test case could fail with:

    #  + mkdir /output
    # + tar -cf /output/installer-iso.tar -C /stacker .
    # tar: ./.coverage: file changed as we read it

The /stacker/.coverage file was being updated by the stacker binary
itself.  This is just a race condition based on when the file gets
written to and when it was being collected by tar.

The change is just to only have tar collect the .cpio files.

Signed-off-by: Scott Moser <smoser@brickies.net>
  • Loading branch information
smoser authored Nov 20, 2023
1 parent a34ebfa commit 236d70e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/dependency-order.bats
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ installer-iso-build:
#!/bin/bash -ex
# populate the iso
mkdir /output
tar -cf /output/installer-iso.tar -C /stacker .
( cd /stacker/imports && tar -cf /output/installer-iso.tar *.cpio )
atomix-installer-iso:
from:
Expand Down

0 comments on commit 236d70e

Please sign in to comment.