feat: add a single working-dir option #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
reviewed
Jan 6, 2023
|
Yeah that's odd - was a hunk of patch (where the stackerdir etc are set relative to workingdir if the former is not set and the latter is) accidentally dropped? |
|
Updated the PR, basically:
|
rchincha
force-pushed
the
single-dir
branch
7 times, most recently
from
56ca427
to
959d75e
Compare
hallyn
reviewed
Feb 2, 2023
rchincha
force-pushed
the
single-dir
branch
2 times, most recently
from
0c45f4a
to
b604a2f
Compare
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 12.08% 12.08% -0.01%
==========================================
Files 44 44
Lines 5451 5452 +1
==========================================
Hits 659 659
- Misses 4675 4676 +1
Partials 117 117
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rchincha
force-pushed
the
single-dir
branch
2 times, most recently
from
a53f613
to
babe013
Compare
Fixes issue project-stacker#377 Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #377
Signed-off-by: Ramkumar Chinchani rchincha@cisco.com
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.