fix: added build-base to package list for static build #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwing123
changed the title
|
Thanks. The commit itself looks good. However, please
" This enables alpine:edge aarch64 image to finish building (allows it to compile C programs)."
|
ashwing123
changed the title
ashwing123
changed the title
ashwing123
changed the title
ashwing123
force-pushed
the
add-build-base
branch
from
9cfeae9
to
e8cd700
Compare
|
Added commit message and PR description/subject changes (edit: sorry forgot some other metadata and was having issues with my keyboard copy paste hence the title changes... Fixed below) |
ashwing123
changed the title
ashwing123
force-pushed
the
add-build-base
branch
3 times, most recently
from
bc3cf20
to
b3a428f
Compare
ashwing123
force-pushed
the
add-build-base
branch
2 times, most recently
from
b3a428f
to
d459354
Compare
|
Note this is not currently mergeable as "The base branch requires all commits to be signed" |
|
Let me check on that |
ashwing123
force-pushed
the
add-build-base
branch
2 times, most recently
from
63423e0
to
9c85059
Compare
This enables alpine:edge aarch64 image to finish building (allows it to compile C programs). Fixes: project-stacker#473 Signed-off-by: Ashwin Gopalan <ashwin.gopalan02@gmail.com>
ashwing123
force-pushed
the
add-build-base
branch
from
9c85059
to
12ab0ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
fixes #473
What does this PR do / Why do we need it:
Enables alpine:edge aarch64 image to finish building (allows it to compile C programs).
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Signed-off-by: Ashwin Gopalan ashwin.gopalan02@gmail.com