build: bind BUILD_D in so you can use a BUILD_D outside of the tree. #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows:
make BUILD_D=/tmp/build
Without the change, only a BUILD_D that was under the stacker
checkout would work.
Note that in order to take advantage of shared GOCACHE and GOPATH,
they must be under BUILD_D (they are by default).
Signed-off-by: Scott Moser <smoser@brickies.net>
hallyn
approved these changes
Oct 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 13.77% 13.77%
=======================================
Files 40 40
Lines 5671 5671
=======================================
Hits 781 781
Misses 4762 4762
Partials 128 128 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows:
Without the change, only a BUILD_D that was under the stacker checkout would work.
Note that in order to take advantage of shared GOCACHE and GOPATH, they must be under BUILD_D (they are by default).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.