ci: add a job to sync 3rd party container images #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
requested changes
Nov 13, 2023
There was a problem hiding this comment.
This feels liek too much text to accomplish what it is doing. Can we just iterate over a loop of images to sync ? (see inline comment).
I don't actually think this will help much to remove dependency on docker.io.
- We still have 'docker://' references in several tests
- we already were syncing these images to a local oci repo in the beginning of the build. That sync is still using docker:// even after ci: point docker registry to local copy #544, so c-i builds still depend on it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage 13.01% 13.01%
=======================================
Files 40 40
Lines 6003 6003
=======================================
Hits 781 781
Misses 5094 5094
Partials 128 128 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
smoser
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.