Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upload stacker binary #556

Merged

Conversation

smoser
Copy link
Contributor

@smoser smoser commented Nov 20, 2023

Uploading a c-i built binary can make it easier for users to test.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Uploading a c-i built binary can make it easier for users to test.

Signed-off-by: Scott Moser <smoser@brickies.net>
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a34ebfa) 54.24% compared to head (090d014) 54.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   54.24%   54.30%   +0.05%     
==========================================
  Files          64       64              
  Lines        7473     7473              
==========================================
+ Hits         4054     4058       +4     
+ Misses       2728     2724       -4     
  Partials      691      691              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smoser
Copy link
Contributor Author

smoser commented Nov 20, 2023

You can see the 'binary' and 'binary-cov' artifacts https://github.com/project-stacker/stacker/actions/runs/6932027516?pr=556 (scroll down, 'Artifacts')

@hallyn
Copy link
Contributor

hallyn commented Nov 20, 2023

Stupid question: how long will github keep these artifacts? I assume this is a handled problem, and it has reasonable retention times and auto-purge ....

if: ${{ matrix.privilege-level == 'priv' }}
with:
# if there is more than 1 go-version, we would need to account for that here.
name: binary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: stacker
^ instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want we can call it stacker. but what that creates is a zip file name 'stacker.zip' which contains stacker. I'd prefer 'binaries' or 'binary' as its an archive (potentially multiple things).

So its not like it is a single thing that that you can download it and use it, in which case 'stacker' and 'stacker-cov' would be the right name.

I'll rename it if you want though.

if: ${{ matrix.privilege-level == 'priv' }}
with:
# if there is more than 1 go-version, we would need to account for that here.
name: binary-cov
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here?

@smoser
Copy link
Contributor Author

smoser commented Nov 20, 2023

Stupid question: how long will github keep these artifacts? I assume this is a handled problem, and it has reasonable retention times and auto-purge ...

90 days by default [1]:

By default, the artifacts and log files generated by workflows are retained for 90 days before they are automatically deleted. You can adjust the retention period, depending on the type of repository:

  • For public repositories: you can change this retention period to anywhere between 1 day or 90 days.
  • For private repositories: you can change this retention period to anywhere between 1 day or 400 days.

When you customize the retention period, it only applies to new artifacts and log files, and does not retroactively apply to existing objects. For managed repositories and organizations, the maximum retention period cannot exceed the limit set by the managing organization or enterprise.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit cd153e6 into project-stacker:main Nov 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants