Fix bom test failures #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
fix/bom-tests-regression
branch
2 times, most recently
from
b405234
to
c1de7a9
Compare
Commit 2f284d8 re-organized the /stacker content layout. Instead of /stacker/tools/static-stacker we have /stacker/bin/stacker. Signed-off-by: Scott Moser <smoser@brickies.net>
The alpine image being used for the sbom test was already being used (and cloned). There is no reason to depend on ghcr.io for it. Signed-off-by: Scott Moser <smoser@brickies.net>
Run the alpine bom test during normal c-i test. This is a quick test (~10 seconds). Having it run as part of c-i will mean that we sniff test the bom path without adding significant time. Signed-off-by: Scott Moser <smoser@brickies.net>
smoser
force-pushed
the
fix/bom-tests-regression
branch
from
c1de7a9
to
d3c8aff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
+ Coverage 53.01% 57.12% +4.10%
==========================================
Files 64 64
Lines 7505 7505
==========================================
+ Hits 3979 4287 +308
+ Misses 2815 2477 -338
- Partials 711 741 +30 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c-i: Un-mark alpine bom test as slow.
Run the alpine bom test during normal c-i test. This is a quick test
(~10 seconds). Having it run as part of c-i will mean that we sniff
test the bom path without adding significant time.
c-i: Add alpine:edge image to those cloned and use it in test.
The alpine image being used for the sbom test was already being
used (and cloned). There is no reason to depend on ghcr.io for it.
Signed-off-by: Scott Moser smoser@brickies.net
test: Fix bom tests to account for /stacker re-org
Commit 2f284d8 re-organized the /stacker content layout.
Instead of /stacker/tools/static-stacker we have /stacker/bin/stacker.
Signed-off-by: Scott Moser smoser@brickies.net