fix: use a umoci which has fix for another empty lgetxattr #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using my tree so builds can happen. Obviously we'll want to get that fix back into github.com/project-stacker/umoci |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
===========================================
+ Coverage 13.02% 57.16% +44.14%
===========================================
Files 40 64 +24
Lines 6059 7520 +1461
===========================================
+ Hits 789 4299 +3510
+ Misses 5138 2479 -2659
- Partials 132 742 +610 ☔ View full report in Codecov by Sentry. |
hallyn
force-pushed
the
2024-01-22/fix-more-empty-lgetxattr
branch
from
1477a15
to
1b334fe
Compare
andaaron
reviewed
Jan 23, 2024
hallyn
force-pushed
the
2024-01-22/fix-more-empty-lgetxattr
branch
from
1b334fe
to
a1ce1ae
Compare
We end up with errors like:
/home/shallyn/stackertest2/roots/test2/overlay/etc/systemd/system/multi-user.target.wants: dropped overlay attrs: user.overlay.origin
error: no data available
get xattr: user.overlay.origin
github.com/opencontainers/umoci/oci/layer.(*tarGenerator).AddFile
/stacker-tree/.build/gopath/pkg/mod/github.com/project-stacker/umoci@v0.0.0-20231025233220-c7bb24d57e98/oci/layer/tar_generate.go:225
github.com/opencontainers/umoci/oci/layer.GenerateInsertLayer.func1.2
Unless there is an actual data i/o error, ignore it. In particular,
if the fs either says eopnotsupp, enodata, or eperm, just assume the
xattr did not actually exist. We have to do this because there are
cases where listxattr will return xattr keys which getxattr will filter
out, and we're expected to ignore those.
Signed-off-by: Serge Hallyn <shallyn@cisco.com>
hallyn
force-pushed
the
2024-01-22/fix-more-empty-lgetxattr
branch
from
a1ce1ae
to
3f1ad55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We end up with errors like:
/home/shallyn/stackertest2/roots/test2/overlay/etc/systemd/system/multi-user.target.wants: dropped overlay attrs: user.overlay.origin error: no data available
get xattr: user.overlay.origin
github.com/opencontainers/umoci/oci/layer.(*tarGenerator).AddFile
/stacker-tree/.build/gopath/pkg/mod/github.com/project-stacker/umoci@v0.0.0-20231025233220-c7bb24d57e98/oci/layer/tar_generate.go:225
github.com/opencontainers/umoci/oci/layer.GenerateInsertLayer.func1.2
Unless there is an actual data i/o error, ignore it. In particular, if the fs either says eopnotsupp, enodata, or eperm, just assume the xattr did not actually exist. We have to do this because there are cases where listxattr will return xattr keys which getxattr will filter out, and we're expected to ignore those.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.