fix: allow bom build and verification for build_only layers #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchincha
force-pushed
the
bom
branch
2 times, most recently
from
b887686
to
e3a22fe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
+ Coverage 55.12% 57.35% +2.23%
==========================================
Files 65 65
Lines 7715 7718 +3
==========================================
+ Hits 4253 4427 +174
+ Misses 2701 2534 -167
+ Partials 761 757 -4 ☔ View full report in Codecov by Sentry. |
rchincha
force-pushed
the
bom
branch
2 times, most recently
from
2cb4c1b
to
10d7c60
Compare
rchincha
changed the title
rchincha
force-pushed
the
bom
branch
2 times, most recently
from
88c2048
to
7de57a8
Compare
stacker builds allow chaining of layer builds. SBOM chaining should follow that model, so bom generation directives are concerned with only that layer. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: allow bom build and verification for
build_onlylayersWhat type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.