fix: check bind source file/dir exists #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raharper
force-pushed
the
fix/check-bind-source-exists
branch
from
b2242c7
to
750964b
Compare
Stacker does not check if a bind mount source exists and if the source is a directory then the container crashes with a stack trace that does not indicate that the missing source dir is the issue. Check if the source exists and return an error indicating the source is missing instead of the container stack trace. Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
raharper
force-pushed
the
fix/check-bind-source-exists
branch
from
750964b
to
9f7f75b
Compare
hallyn
approved these changes
Jun 11, 2024
mikemccracken
added a commit
to mikemccracken/stacker
that referenced
this pull request
Jun 11, 2024
Just copied Ryan's test from the description of project-stacker#624 with minimal editing. Signed-off-by: Michael McCracken <mikmccra@cisco.com>
mikemccracken
added a commit
that referenced
this pull request
Jul 24, 2024
Just copied Ryan's test from the description of #624 with minimal editing. Signed-off-by: Michael McCracken <mikmccra@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacker does not check if a bind mount source exists and if the source is a directory then the container crashes with a stack trace that does not indicate that the missing source dir is the issue.
Check if the source exists and return an error indicating the source is missing instead of the container stack trace.
What type of PR is this?
bug
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Above test returns an error indicating that the source directory in binds is missing.
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.