Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build stacker on Ubuntu 24.04 LTS (noble) #644
Build stacker on Ubuntu 24.04 LTS (noble) #644
Changes from all commits
1fb1d2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, it probably doesn't matter as I don't think it'll fail on undefined variables, but I think you meant for LXC_WRAPPER_LIBS= to also happen if it's not 24.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't. On 24.04, the
lxc-wrapper
binary requires a static link to systemd;and
pkg-config --static --libs lxc
does not emit an-lsystemd
.However on 22.04; it doesn't seem to require the
-lsystemd
; I'm not exactly sure why; I assume it's related to how theliblxc.a
is built in thelxc-dev
package in 24.04 vs what's in 22.04?The intention then is to append the
-lsystemd
when makingstacker-dynamic
but to omit the link when we createstacker-static
which is compiled inside a stacker root we constructed, and there, we don't use/need systemd since we compile our own lxc lib.