fix: handle overlay xattr opaque bit #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behavior determines if a path is a whiteout if a overlay char dev is present. Additionally, also check the extended attrs. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
added a commit
to rchincha/stacker
that referenced
this pull request
Mar 29, 2024
project-stacker/umoci#6 overlayfs may set 'user.overlay.opaque=y' for deleted directories. The above PR fixes this handling in our fork of umoci. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
hallyn
added a commit
to project-stacker/stacker
that referenced
this pull request
Mar 29, 2024
* feat: test directory removals Add some tests to make sure when a directory is removed, its contents are not visible later on. Signed-off-by: Serge Hallyn <serge@hallyn.com> * test: fix the directory removals test project-stacker/umoci#6 overlayfs may set 'user.overlay.opaque=y' for deleted directories. The above PR fixes this handling in our fork of umoci. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> --------- Signed-off-by: Serge Hallyn <serge@hallyn.com> Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> Co-authored-by: Serge Hallyn <serge@hallyn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.