Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED-3079: deploy nginx to support cors for s3 compatible object storage #3915

Merged

Conversation

ddevadat
Copy link

@ddevadat ddevadat commented Oct 31, 2023

BugED-3079 deploy nginx to support cors for s3 compatible object storage

OCI s3 compatible url doesnt support CORS.

While using s3 compatible url in the form of https://.compat.objectstorage..oraclecloud.com works in most of the case, it will not work where CORS is involved. So any AJAX call going from player will fail.

In order to provide appropriate CORS response, there should be something in place when using S3 Compatible API URL with a Web Application (that is the Sunbird-ED portal, aka player) which required AJAX requests. It can be CDN, LB, RP or combination of them.

a new proxy config has been added to public ingress chart. This is a conditional block only for oci

once public-nginx-ingress is created, Use this public ip to add a dns zone record with the name
files.{{domain_name}}

e.g if your domain_name is ed.sunbird.in, then the record should files.ed.sunbird.in

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
@ddevadat
Copy link
Author

ddevadat commented Nov 1, 2023

@santhosh-tg updated the PR.
In this approach instead of creating a new deployment and lb, added the proxy config for cors in the existing nginx-public-ingress. Please review if this works.

@gandham-santhosh gandham-santhosh merged commit 0d2daa4 into project-sunbird:release-6.0.0 Feb 28, 2024
santhosh-tg pushed a commit to santhosh-tg/sunbird-devops that referenced this pull request Apr 25, 2024
project-sunbird#3915)

* nginx-cors

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* hostname changed

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* added nginx-cors-public chart

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* corrected proxy conf

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* corrected syntax

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* changed nodeport

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed duplicate

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* nodeport change

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* nodeport change

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* changed public ip

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed nginx-cors ansible roles

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* added jenkins job for nginx-cors-public deployment

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* updated variable in values.j2

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* testing public ingress along with s3 cors

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* testing with condition for csp

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed nginx-cors-public

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

---------

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
gandham-santhosh pushed a commit that referenced this pull request May 6, 2024
* Fix syntax (#3894)

* Updated vars for cron schedule (#3895)

* Updated vars for cron schedule

* Update main.yml

* [ED-2793] Fix: release-6.0.0 installation issues  (#3900)

* Update Jenkins version

* Fix job parameter

* Fix error: You need to install jmespath prior to running json_query filter

* Update main.yml with cassandra (#3845) (#3901)

Co-authored-by: gohilamariappan <41056032+gohilamariappan@users.noreply.github.com>

* ED-2838: ##Release-6.0.0 new variables (#3899)

* ED-2838 Release-6.0.0 new variables

* Added with comments

* ED-2838 jenkins josb update and new variables

* added storage endpoint detials

* [ED-2793] Fix installation issues (#3905)

* Update maven repo url

* Add missing jobs

* Fix docker creds secrets issue when having specialcharacters

* [ED-2793] Add OCI specific vars (#3912)

* Add OCI specific vars

* Add mobile deeplink url var

* Add ml_core_internal_access_token for private repo template

Add ml_core_internal_access_token for private repo template

* Update cassandra jenkins job config (#3927)

* saving changes (#3935)

Co-authored-by: ankitshahu <ankit@matchlog.delivery>

* #OB-553 fix: Analytics service issue fixes for OCI

* #OB-553 fix: Analytics service issue fixes for OCI

* ED-3534:- Adoption Changes in ML service (#3963)

* saving changes

* added Upload api endpoint in public kong

---------

Co-authored-by: ankitshahu <ankit@matchlog.delivery>

* ED-3079: deploy nginx to support cors for s3 compatible object storage (#3915)

* nginx-cors

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* hostname changed

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* added nginx-cors-public chart

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* corrected proxy conf

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* corrected syntax

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* changed nodeport

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed duplicate

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* nodeport change

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* nodeport change

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* changed public ip

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed nginx-cors ansible roles

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* added jenkins job for nginx-cors-public deployment

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* updated variable in values.j2

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* testing public ingress along with s3 cors

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* testing with condition for csp

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed nginx-cors-public

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

---------

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* Added new kafka topics in main.yml and config.j2 (#3970)

* Issue #CO-824: dynamic redirect URL

* Issue #CO-824: dynamic redirect URL

* Issue #CO-824: SSO Isse condition update

* Issue ED-0000 report service env update

* Issue ED-0000 report service env update (#3977)

* Issue ED-0000 report service env update

* Issue ED-0000 report service env update (#3981)

* ED-3534:- Adoption Changes in ML service (#3983)

* helm chart for ml-analytics

* Update and rename values.yaml to values.j2

* Update main.yml

* Update ml-analytics-service.conf

* Update ml-analytics-service.conf

* Delete kubernetes/helm_charts/core/ml-analytics-service/templates/NOTES.txt

* Update deployment.yaml

* Update deployment.yaml

* Update deployment.yaml

* Update values.j2

* Update deployment.yaml

* Update deployment.yaml

* Update ml-analytics-service.conf

* Update deployment.yaml

* Update ml-analytics-service.conf

* Update ml-analytics-service.conf

* Update ml-analytics-service.conf

* Update ml-analytics-service.conf

* Updated ml-analytics-service.conf

* added new kafka topics for observations

* Update ml-analytics-service.conf

---------

Co-authored-by: raghupathi <raghupathi.g@optit.in>
Co-authored-by: Raghupathi Guduri <raghupathiguduri@gmail.com>

* Issue #IQ-750 fix: added script for inquiry schema upload

* Issue #IQ-750 fix: updated jenkins file

* added the faust related changes

* Issue #IQ-750 fix: updated jenkins script

* added the value to ml_analytics_faust_applications_list

* Update secrets.yml

* ED-3534:- Adoption Changes in ML service (#3993)

* updated druid ports

* updated druid ports

* key changes

* key changes

---------

Co-authored-by: vivek <user@PWA177.local>

* Add release-6.0.0 missing vars

* Add release-6.0.0 missing vars (#3995)

* Add inquiry-schema-upload Jenkinsfile

---------

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Co-authored-by: Raghupathi Guduri <raghupathiguduri@gmail.com>
Co-authored-by: gohilamariappan <41056032+gohilamariappan@users.noreply.github.com>
Co-authored-by: Prasath Sivasubramaniyan <tsprasath91@gmail.com>
Co-authored-by: Akash Shah <aks301190@gmail.com>
Co-authored-by: Ankit Shahu <ankit.shahu@hotmail.com>
Co-authored-by: ankitshahu <ankit@matchlog.delivery>
Co-authored-by: sowmya-dixit <sowmyadixit7@gmail.com>
Co-authored-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Co-authored-by: Prashant Gunjeti <153811259+prashanthShiksha@users.noreply.github.com>
Co-authored-by: Shubham Bansal <shubhambansal@TI-MAC-070.local>
Co-authored-by: Rajeev Sathish <rajeev.sathish@tarento.com>
Co-authored-by: Vivek M <125434153+Vivek-M-08@users.noreply.github.com>
Co-authored-by: raghupathi <raghupathi.g@optit.in>
Co-authored-by: Kumar Gauraw <er.krgauraw@gmail.com>
Co-authored-by: vivek <user@PWA177.local>
santhosh-tg pushed a commit to santhosh-tg/sunbird-devops that referenced this pull request Jun 27, 2024
project-sunbird#3915)

* nginx-cors

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* hostname changed

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* added nginx-cors-public chart

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* corrected proxy conf

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* corrected syntax

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* changed nodeport

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed duplicate

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* nodeport change

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* nodeport change

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* changed public ip

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* test

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed nginx-cors ansible roles

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* added jenkins job for nginx-cors-public deployment

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* updated variable in values.j2

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* testing public ingress along with s3 cors

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* testing with condition for csp

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

* removed nginx-cors-public

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>

---------

Signed-off-by: Deepak Devadathan <deepak.devadathan@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants