Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Upgrade go dependencies to newest majors #2522

Open
AndersBennedsgaard opened this issue Jul 3, 2024 · 4 comments
Open

[Feat]: Upgrade go dependencies to newest majors #2522

AndersBennedsgaard opened this issue Jul 3, 2024 · 4 comments
Labels
feature New feature or request rm-external Roadmap item submitted by non-maintainers

Comments

@AndersBennedsgaard
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I noticed that Zot use github.com/zitadel/oidc v1.13.5, when the newest version is v3.25.1:

zot/go.mod

Line 63 in 002ff05

github.com/zitadel/oidc v1.13.5

This led me to try running gomajor on Zot, and i found multiple dependencies that should be upgraded (using gomajor list):

github.com/aws/aws-sdk-go: v1.54.11 [latest v1.54.13]
github.com/containers/common: v0.59.1 [latest v1.0.1]
github.com/didip/tollbooth/v6: v6.1.2 [latest v7.0.2]
github.com/google/go-github/v52: v52.0.0 [latest v62.0.0]
github.com/sigstore/sigstore: v1.8.4 [latest v1.8.6]
github.com/swaggo/http-swagger: v1.3.4 [latest v2.0.2]
github.com/zitadel/oidc: v1.13.5 [latest v3.25.1]
gopkg.in/resty.v1: v1.12.0 [latest v2.13.1]
gopkg.in/yaml.v2: v2.4.0 [latest v3.0.1]

Most notably, github.com/containers/common v1 is released, github.com/google/go-github has 10 new major versions, and github.com/zitadel/oidc v3 are released

Describe the solution you'd like

Upgrade the dependencies

Describe alternatives you've considered

No response

Additional context

No response
@AndersBennedsgaard AndersBennedsgaard added the feature New feature or request label Jul 3, 2024
@rchincha
Copy link
Contributor

rchincha commented Jul 3, 2024

@AndersBennedsgaard Some of these deps are used for test code and others not. We have started looking at the zitadel dep.

@rchincha
Copy link
Contributor

rchincha commented Jul 8, 2024

@AndersBennedsgaard if you are planning to submit a PR for this, we approve and very interested.

@rchincha rchincha added the rm-external Roadmap item submitted by non-maintainers label Jul 9, 2024
@rchincha
Copy link
Contributor

github.com/zitadel/oidc v3 are released

^ this has been resolved

rchincha added a commit to rchincha/zot that referenced this issue Aug 13, 2024
@rchincha
chore: update go.mod deps
0415f9f 
Fix outdated pkgs reported in issue project-zot#2522

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha added a commit to rchincha/zot that referenced this issue Aug 13, 2024
@rchincha
chore: update go.mod deps
95af2ca 
Fix outdated pkgs reported in issue project-zot#2522

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha rchincha mentioned this issue Aug 13, 2024
Merged
rchincha added a commit that referenced this issue Aug 13, 2024
@rchincha
chore: update go.mod deps (#2609)
2a164cc 
Fix outdated pkgs reported in issue #2522

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha added a commit to rchincha/zot that referenced this issue Aug 13, 2024
@rchincha
chore: update go.mod deps
00c193d 
Fix outdated pkgs reported in issue project-zot#2522

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha rchincha mentioned this issue Aug 13, 2024
Merged
rchincha added a commit to rchincha/zot that referenced this issue Aug 14, 2024
@rchincha
chore: update go.mod deps
4f851df 
Fix outdated pkgs reported in issue project-zot#2522

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha added a commit that referenced this issue Aug 14, 2024
@rchincha
chore: update go.mod deps (#2610)
1acf124 
Fix outdated pkgs reported in issue #2522

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@rchincha
Copy link
Contributor

gopkg.in/yaml.v2: v2.4.0 [latest v3.0.1]
^ this is done also

gopkg.in/resty.v1: v1.12.0 [latest v2.13.1]
^ this is next

andaaron pushed a commit that referenced this issue Aug 20, 2024
@rchincha
Fix deps (#2621)
bfafe01 
* chore: update go.mod deps

Fix outdated pkgs reported in issue #2522

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>

* chore: fix dependabot alerts

#2612
#2613
#2614
#2615
#2616
#2617
#2618
#2619
#2620
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>

---------

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request rm-external Roadmap item submitted by non-maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndersBennedsgaard @rchincha