Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redis dedup backend #2005

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

elee1766
Copy link
Contributor

@elee1766 elee1766 commented Nov 3, 2023

hi ! im attempting to implement #2004

im not done yet (i need to add the configuration switch case and look at other things), but i thought i would push up some progress, and maybe if this is an awful idea or i am doing something very bad code wise i should know.

it passes tests using an embedded redis, so that is good

What does this PR do / Why do we need it:

adds a redis backend for the dedup cache

Testing done on this change:

i've copied the test from bolt and ran it with embedded redis.

Automation added to e2e:

not any. should i add a test that spins up redis docker image?

Will this break upgrades or downgrades?

it will break downgrades if the user downgrades to a version that no longer supports redis and they are using redis

Does this PR introduce any user-facing change?:


adds redis as backend for dedup cache

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brandond
Copy link

brandond commented Nov 9, 2023

I would love to see Redis support added. Are you still working on this?

@elee1766
Copy link
Contributor Author

elee1766 commented Nov 9, 2023

I would love to see Redis support added. Are you still working on this?

hi yes, I plan to see this pr to completion

@rchincha
Copy link
Contributor

@elee1766 Thanks for all the work you are doing ...

Just FYI,

#1395
#2041

@rchincha
Copy link
Contributor

rchincha commented Apr 4, 2024

@elee1766
There is a user requirement for this feature.
#2365

We can take over this PR.

@rchincha rchincha added this to the v2.1.0 milestone Apr 4, 2024
@rchincha rchincha linked an issue Apr 4, 2024 that may be closed by this pull request
rchincha pushed a commit to rchincha/zot that referenced this pull request Apr 8, 2024
eusebiu-constantin-petu-dbk pushed a commit to eusebiu-constantin-petu-dbk/zot that referenced this pull request Apr 30, 2024
adodon2go pushed a commit to adodon2go/zot that referenced this pull request Jul 2, 2024
eusebiu-constantin-petu-dbk pushed a commit to eusebiu-constantin-petu-dbk/zot that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: redis backend for dedup cache
3 participants