Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and clean up dependencies #763

Conversation

kblaschke
Copy link
Member

A bunch of cleanup tasks I've postponed for a long time:

  • Removed no longer required OpenMP dependency
  • Removed no longer required LLVM dependency
  • Removed custom random number generator functions and replaced them with std::random
  • Removed useless multithreading code in ProjectM class
  • Fixed pkgconfig files (include boost_filesystem library if required)
  • Silenced OpenGL deprecation warning on macOS when building with SDK 10.14 or higher
  • Cleaned up include statements
  • Some other small things moved around and fixed

@kblaschke kblaschke added this to the 4.1 milestone Feb 1, 2024
Most files ignored were no longer in the repository, and the rest is already covered by the top-level .gitignore file.
Nothing we can do about that in the short term. We might support Metal (eventually via MetalVK) in a future version.
Since we're using OpenGL, everything has to be done in the same thread anyways. Besides that, the actual "multithreading" implementation was basically starting an empty thread that did absolutely nothing, then wait synchronously for it to complete and join it on the next frame.
Also removed empty FrameAudioData implementation file.
@kblaschke kblaschke force-pushed the remove-and-clean-up-dependencies branch from 5d70008 to 60e5607 Compare February 2, 2024 14:08
@kblaschke kblaschke merged commit 60e5607 into projectM-visualizer:master Feb 2, 2024
9 checks passed
@kblaschke kblaschke deleted the remove-and-clean-up-dependencies branch February 2, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants